Closed
Bug 1173746
Opened 9 years ago
Closed 9 years ago
Remove Windows Vista / 7 style hover effect from autocomplete items on Windows 8 and 10
Categories
(Toolkit :: Themes, defect)
Tracking
()
VERIFIED
FIXED
mozilla41
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.87 KB,
patch
|
Gijs
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Stephen, are you okay with making this change on Windows 8 too? It feels more natural to me than what we currently do there, but I haven't used Windows 8 extensively.
Flags: needinfo?(shorlander)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8621470 -
Flags: review?(gijskruitbosch+bugs)
Comment 4•9 years ago
|
||
Comment on attachment 8621470 [details] [diff] [review] patch Review of attachment 8621470 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, but while we're here, can you file a followup that you basically can't see the (dark blue) star for bookmarked autocomplete items with the default windows highlight color that we now use? I suppose this is why it used to be yellow... Doesn't necessarily need to block this bug itself because it was obviously already an issue for winxp luna, classic, and some high contrast themes (though we don't seem to have picked up on it) but we might still want to fix it in our win10 polish project now that it applies to win8 and win10 as well, so I guess it could potentially block the UX update for win10 still? Your choice.
Attachment #8621470 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 5•9 years ago
|
||
filed bug 1174122
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/362466a2807d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8621470 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: Windows 10 [User impact if declined]: URL bar autocomplete popup looks alien on Windows 10 [Describe test coverage new/current, TreeHerder]: no test coverage [Risks and why]: low risk, only changing CSS media queries [String/UUID change made/needed]: none
Attachment #8621470 -
Flags: approval-mozilla-beta?
Attachment #8621470 -
Flags: approval-mozilla-aurora?
Comment 9•9 years ago
|
||
Does this need to go into beta? I think we are aiming for 40 for most of the windows 10 changes.
Flags: needinfo?(dao)
Updated•9 years ago
|
status-firefox39:
--- → wontfix
status-firefox40:
--- → affected
Comment 10•9 years ago
|
||
Comment on attachment 8621470 [details] [diff] [review] patch As Liz said, Windows 10 changes are for 40.
Attachment #8621470 -
Flags: approval-mozilla-beta?
Attachment #8621470 -
Flags: approval-mozilla-beta-
Attachment #8621470 -
Flags: approval-mozilla-aurora?
Attachment #8621470 -
Flags: approval-mozilla-aurora+
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(dao)
Comment 12•9 years ago
|
||
Confirming the fix on Windows 10 32-bit and Windows 8 64-bit using: - latest Nightly, build ID: 20150621030204; - latest Aurora, build ID: 20150621004005.
You need to log in
before you can comment on or make changes to this bug.
Description
•