Remove Windows Vista / 7 style hover effect from autocomplete items on Windows 8 and 10

VERIFIED FIXED in Firefox 40

Status

()

Toolkit
Themes
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla41
Unspecified
Windows 10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 wontfix, firefox40 verified, firefox41 verified)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Stephen, are you okay with making this change on Windows 8 too? It feels more natural to me than what we currently do there, but I haven't used Windows 8 extensively.
Flags: needinfo?(shorlander)
Yes, it will be an improvement there too.
Flags: needinfo?(shorlander)
(Assignee)

Comment 3

3 years ago
Created attachment 8621470 [details] [diff] [review]
patch
Attachment #8621470 - Flags: review?(gijskruitbosch+bugs)

Comment 4

3 years ago
Comment on attachment 8621470 [details] [diff] [review]
patch

Review of attachment 8621470 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but while we're here, can you file a followup that you basically can't see the (dark blue) star for bookmarked autocomplete items with the default windows highlight color that we now use? I suppose this is why it used to be yellow... Doesn't necessarily need to block this bug itself because it was obviously already an issue for winxp luna, classic, and some high contrast themes (though we don't seem to have picked up on it) but we might still want to fix it in our win10 polish project now that it applies to win8 and win10 as well, so I guess it could potentially block the UX update for win10 still? Your choice.
Attachment #8621470 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Comment 5

3 years ago
filed bug 1174122
https://hg.mozilla.org/mozilla-central/rev/362466a2807d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(Assignee)

Comment 8

3 years ago
Comment on attachment 8621470 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Windows 10
[User impact if declined]: URL bar autocomplete popup looks alien on Windows 10
[Describe test coverage new/current, TreeHerder]: no test coverage
[Risks and why]: low risk, only changing CSS media queries
[String/UUID change made/needed]: none
Attachment #8621470 - Flags: approval-mozilla-beta?
Attachment #8621470 - Flags: approval-mozilla-aurora?
Does this need to go into beta? I think we are aiming for 40 for most of the windows 10 changes.
Flags: needinfo?(dao)
status-firefox39: --- → wontfix
status-firefox40: --- → affected
Comment on attachment 8621470 [details] [diff] [review]
patch

As Liz said, Windows 10 changes are for 40.
Attachment #8621470 - Flags: approval-mozilla-beta?
Attachment #8621470 - Flags: approval-mozilla-beta-
Attachment #8621470 - Flags: approval-mozilla-aurora?
Attachment #8621470 - Flags: approval-mozilla-aurora+
(Assignee)

Updated

3 years ago
Flags: needinfo?(dao)
Confirming the fix on Windows 10 32-bit and Windows 8 64-bit using:
- latest Nightly, build ID: 20150621030204;
- latest Aurora, build ID: 20150621004005.
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
status-firefox41: fixed → verified
You need to log in before you can comment on or make changes to this bug.