Closed Bug 1173747 Opened 5 years ago Closed 5 years ago

URL and search bar autocomplete popup's border should be lighter on Windows 10

Categories

(Firefox :: Theme, defect, P1)

Unspecified
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 41
Tracking Status
firefox40 --- verified
firefox41 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Priority: -- → P1
I believe this is roughly as unpolished as on Windows 8 and as such we'd ship without it...

In fact, let me needinfo phlsa to clarify to what extent this is really Windows-10-specific.
Flags: needinfo?(philipp)
Priority: P1 → P3
I took a look myself; we use basically the same style on Windows 8 and 10, but on 8 it seems more in line with what other applications do.
Flags: needinfo?(philipp)
Priority: P3 → P1
Summary: URL and search bar autocomplete popup's border should be lighter → URL and search bar autocomplete popup's border should be lighter on Windows 10
Attached patch patchSplinter Review
Just switching to ThreeDShadow as discussed with Stephen. I don't think we need to limit this change to Windows 10.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8625832 - Flags: review?(jaws)
Attachment #8625832 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/c843008bfe6f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8625832 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: windows 10
[User impact if declined]: aesthetics
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: trivial CSS patch, not risky
[String/UUID change made/needed]: none
Attachment #8625832 - Flags: approval-mozilla-aurora?
Flags: qe-verify+
Comment on attachment 8625832 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:
Attachment #8625832 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
The border seems darker than the one from the mock-ups: http://i.imgur.com/3WumZS2.png 
Is this the desired implementation?

Tested on Windows 10 (build 10158) 64-bit using latest Nightly, build ID: 20150701030207.
Flags: needinfo?(dao)
(In reply to Cornel Ionce [QA] from comment #8)
> The border seems darker than the one from the mock-ups:
> http://i.imgur.com/3WumZS2.png 
> Is this the desired implementation?

Yep, as briefly mentioned in comment 3.
Flags: needinfo?(dao)
Based on the above comments we can consider this issue verified.

Thanks Dao!
Status: RESOLVED → VERIFIED
QA Contact: cornel.ionce
Comment on attachment 8625832 [details] [diff] [review]
patch

Verified visual fix for Windows 10. Beta+
Attachment #8625832 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Also verified on Firefox 40 beta 2, build ID: 20150706172413.
You need to log in before you can comment on or make changes to this bug.