Closed
Bug 1173747
Opened 9 years ago
Closed 9 years ago
URL and search bar autocomplete popup's border should be lighter on Windows 10
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 41
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
935 bytes,
patch
|
Gijs
:
review+
jaws
:
review+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Updated•9 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•9 years ago
|
||
I believe this is roughly as unpolished as on Windows 8 and as such we'd ship without it... In fact, let me needinfo phlsa to clarify to what extent this is really Windows-10-specific.
Flags: needinfo?(philipp)
Priority: P1 → P3
Assignee | ||
Comment 2•9 years ago
|
||
I took a look myself; we use basically the same style on Windows 8 and 10, but on 8 it seems more in line with what other applications do.
Flags: needinfo?(philipp)
Priority: P3 → P1
Summary: URL and search bar autocomplete popup's border should be lighter → URL and search bar autocomplete popup's border should be lighter on Windows 10
Assignee | ||
Comment 3•9 years ago
|
||
Just switching to ThreeDShadow as discussed with Stephen. I don't think we need to limit this change to Windows 10.
Updated•9 years ago
|
Attachment #8625832 -
Flags: review?(jaws) → review+
Updated•9 years ago
|
Attachment #8625832 -
Flags: review+
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c843008bfe6f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8625832 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: windows 10 [User impact if declined]: aesthetics [Describe test coverage new/current, TreeHerder]: none [Risks and why]: trivial CSS patch, not risky [String/UUID change made/needed]: none
Attachment #8625832 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox40:
--- → affected
Updated•9 years ago
|
Flags: qe-verify+
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8625832 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: [Describe test coverage new/current, TreeHerder]: [Risks and why]: [String/UUID change made/needed]:
Attachment #8625832 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Comment 8•9 years ago
|
||
The border seems darker than the one from the mock-ups: http://i.imgur.com/3WumZS2.png Is this the desired implementation? Tested on Windows 10 (build 10158) 64-bit using latest Nightly, build ID: 20150701030207.
Flags: needinfo?(dao)
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to Cornel Ionce [QA] from comment #8) > The border seems darker than the one from the mock-ups: > http://i.imgur.com/3WumZS2.png > Is this the desired implementation? Yep, as briefly mentioned in comment 3.
Flags: needinfo?(dao)
Comment 10•9 years ago
|
||
Based on the above comments we can consider this issue verified. Thanks Dao!
Comment 11•9 years ago
|
||
Comment on attachment 8625832 [details] [diff] [review] patch Verified visual fix for Windows 10. Beta+
Attachment #8625832 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 13•9 years ago
|
||
Also verified on Firefox 40 beta 2, build ID: 20150706172413.
You need to log in
before you can comment on or make changes to this bug.
Description
•