1173755 - Update security tests for new identity popup panel

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like there happened a change in Firefox Nightly since yesterday which causes us to fail in retrieving the encryption label inside the identity popup. Here the related traceback:

Traceback (most recent call last):
  File "/home/henrik/.virtualenvs/fxtests/local/lib/python2.7/site-packages/marionette_client-0.12-py2.7.egg/marionette/marionette_test.py", line 296, in run
    testMethod()
  File "/mozilla/code/firefox-ui-tests/firefox_ui_harness/decorators.py", line 23, in wrapper
    return target(self, *args, **kwargs)
  File "/mozilla/code/firefox-ui-tests/firefox_puppeteer/tests/test_toolbars.py", line 175, in test_popup_elements
    self.assertEqual(self.identity_popup.encryption_label.get_attribute('localName'),
  File "/mozilla/code/firefox-ui-tests/firefox_puppeteer/ui/toolbars.py", line 368, in encryption_label
    return self.marionette.find_element(By.ID, 'identity-popup-encryption-label')
  File "/home/henrik/.virtualenvs/fxtests/local/lib/python2.7/site-packages/marionette_driver-0.7-py2.7.egg/marionette_driver/marionette.py", line 1538, in find_element
    response = self._send_message('findElement', 'value', **kwargs)
  File "/home/henrik/.virtualenvs/fxtests/local/lib/python2.7/site-packages/marionette_driver-0.7-py2.7.egg/marionette_driver/decorators.py", line 36, in _
    return func(*args, **kwargs)
  File "/home/henrik/.virtualenvs/fxtests/local/lib/python2.7/site-packages/marionette_driver-0.7-py2.7.egg/marionette_driver/marionette.py", line 711, in _send_message
    self._handle_error(response)
  File "/home/henrik/.virtualenvs/fxtests/local/lib/python2.7/site-packages/marionette_driver-0.7-py2.7.egg/marionette_driver/marionette.py", line 747, in _handle_error
    raise errors.lookup(status)(message, stacktrace=stacktrace)
NoSuchElementException: NoSuchElementException: Unable to locate element: identity-popup-encryption-label

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This regressed with the landing of the patch on bug 1146269. I'm working on a fix.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I did a wrong query, so this is actually a regression from bug 1146282.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The new panel can be found here:
http://mxr.mozilla.org/mozilla-central/source/browser/components/controlcenter/content/panel.inc.xul

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: github_pull_request.txt

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8621206 [details] [review]
github_pull_request.txt

Looks good.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://github.com/mozilla/firefox-ui-tests/commit/7fec256ab1a9970ab5cfd5ff2df14ee1490fa4fb