Closed Bug 1173764 Opened 5 years ago Closed 5 years ago

Enable LAllocation / LUse spew in optimized build.

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: nbp, Assigned: nbp)

Details

Attachments

(2 files)

The Jit DevTools addons, which is based on the Debugger.onIonCompilation hook has a view on the LIR, unfortunately, when using an optimized build, most of the relevant informations are replaced by "???", in the spew of the LIR.

The incoming patch removes the #ifdef DEBUG macro to enable this code in optimized build, as well.
Comment on attachment 8621016 [details] [diff] [review]
Enable LAllocation/LUse serialization in optimized builds.

Review of attachment 8621016 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately, there are some places where we use call these toString() functions in release builds and want these to be no-ops.  AFAIK this is only when calling JitSpew and then passing the result of toString() as one of the varargs.  It would be good if these places didn't incur an uninlined call in release builds, so can you either add #ifdef DEBUG around the JitSpew calls where we invoke one of these toString() methods, or add a separate method to LAllocation/LDefinition that always computes the string representation of the thing?
Attachment #8621016 - Flags: review?(bhackett1024)
I hope this would be convincing enough.
Attachment #8621087 - Flags: review?(bhackett1024)
Comment on attachment 8621087 [details] [diff] [review]
Disable JitSpew argument computation in optimizied builds.

Review of attachment 8621087 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8621087 - Flags: review?(bhackett1024) → review+
Attachment #8621016 - Flags: review?(bhackett1024)
Comment on attachment 8621016 [details] [diff] [review]
Enable LAllocation/LUse serialization in optimized builds.

Review of attachment 8621016 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.
Attachment #8621016 - Flags: review?(bhackett1024) → review+
Flags: needinfo?(nicolas.b.pierron)
https://hg.mozilla.org/mozilla-central/rev/f7e05fb33ae6
https://hg.mozilla.org/mozilla-central/rev/48a236be1369
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.