1173764 - Enable LAllocation / LUse spew in optimized build.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Nicolas B. Pierron [:nbp]]

The Jit DevTools addons, which is based on the Debugger.onIonCompilation hook has a view on the LIR, unfortunately, when using an optimized build, most of the relevant informations are replaced by "???", in the spew of the LIR.

The incoming patch removes the #ifdef DEBUG macro to enable this code in optimized build, as well.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Enable LAllocation/LUse serialization in optimized builds.

Comment 2

[Brian Hackett [Laid off!]]

Comment on attachment 8621016 [details] [diff] [review]
Enable LAllocation/LUse serialization in optimized builds.

Review of attachment 8621016 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately, there are some places where we use call these toString() functions in release builds and want these to be no-ops.  AFAIK this is only when calling JitSpew and then passing the result of toString() as one of the varargs.  It would be good if these places didn't incur an uninlined call in release builds, so can you either add #ifdef DEBUG around the JitSpew calls where we invoke one of these toString() methods, or add a separate method to LAllocation/LDefinition that always computes the string representation of the thing?

Comment 3

[Nicolas B. Pierron [:nbp]]

Attachment: Disable JitSpew argument computation in optimizied builds.

I hope this would be convincing enough.

Comment 4

[Brian Hackett [Laid off!]]

Comment on attachment 8621087 [details] [diff] [review]
Disable JitSpew argument computation in optimizied builds.

Review of attachment 8621087 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Brian Hackett [Laid off!]]

Comment on attachment 8621016 [details] [diff] [review]
Enable LAllocation/LUse serialization in optimized builds.

Review of attachment 8621016 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13a9a4428a68
https://hg.mozilla.org/integration/mozilla-inbound/rev/0aa70076583f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://treeherder.mozilla.org/logviewer.html#?job_id=10965460&repo=mozilla-inbound

Comment 8

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c42035bc7f8

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7e05fb33ae6
https://hg.mozilla.org/integration/mozilla-inbound/rev/48a236be1369

Comment 10

[Nicolas B. Pierron [:nbp]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e7997618fc4
https://treeherder.mozilla.org/#/jobs?repo=try&revision=082e065cdb99

Thanks Benjamin for the reminder. :)

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f7e05fb33ae6
https://hg.mozilla.org/mozilla-central/rev/48a236be1369