1173782 - [LogShake] Cancelling the activity dismisses the notification

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Steps to reproduce
1. Enable logshake and shake your device up (or press vol-up + vol-down on an Aries device)
2. Tap the notification and select share to Bluetooth
3. Cancel the activity by pressing X

Expected results
As you weren't able to send the results of the logshake, the notification remains and you're able to tap to start the operation again.

Actual results
The notification disappears.

Notes:
We already discussed with :gerard-majax of this edge case, saying that it was minor, back in the days where sending an email was the only option to share the logs. In the email case, the draft is still saved in the email app, so you're able to send the files another time.
However, in the case of bluetooth, the only way to restart is to perform another logshake. This can be problematic if we wanted to log a race condition.

Comment 1

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Fixing this case would prevent frustration for future dogfooders.

Comment 2

[:gerard-majax]

Should not be too hard, probably just having to handle the return status of the activity ..

Comment 3

[:gerard-majax]

Attachment: Gaia PR

Not that hard, indeed. Johan, could you check on your side? Thanks!

Comment 4

[:gerard-majax]

Comment on attachment 8621557 [details] [review]
Gaia PR

Dale, would you mind giving this a review ? Thanks!

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 8621557 [details] [review]
Gaia PR

This looks great, cheers

Comment 6

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/80d1e3b281ac036d0c6aa647ae0f0fa3388e050b

Comment 7

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on Aries. Pressing 'X' on bluetooth discovery page does not make the notification disappear from notification bar.

I did notice another issue that the logshake is not automatically shared if I pair with the another device on this screen. Looking into bugging this separately.

Device: Aries (dogfood debug build)
BuildID: 20150721153949
Gaia: 805cf546729ba742bf23febda52970fcb35c0e8f
Gecko: 512c7e8f0030
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5 Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

Correction on verified behavior: Pressing 'X' on bluetooth discovery page does not make the notification disappear from notification *tray*.