1173829 - Codegen doesn't like non-concrete static interfaces

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Doesn't generate includes of implementations.

Also "no member named 'GetProtoObjectHandle' in namespace 'mozilla::dom::ThreadSafeChromeUtilsBinding'".

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix some compile issues in code generated by bindings codegen for non-concrete interfaces

Specifically, two issues:

1)  We didn't include the implementation header for a non-concrete empty
interface.  But if it has a parent we assert it's refcounted if and only if the
parent is refcounted, so need to see the class declaration.

2)  We were getting the parent proto in all cases in CreateInterfaceObjects.
But parent may not have a proto at all if it has no concrete descendants.  So
this patch switches to getting the parent proto only if we have a proto ourselves.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 8621019 [details] [diff] [review]
Fix some compile issues in code generated by bindings codegen for non-concrete interfaces

Review of attachment 8621019 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +2735,5 @@
>          else:
>              protoClass = "nullptr"
>              protoCache = "nullptr"
> +            getParentProto = None
> +            parentProto = "nullptr"

Maybe put these in the same order as above?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Maybe put these in the same order as above?

Done.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec6773c9131c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ec6773c9131c