[quick-settings] Icons aren't vertically aligned

RESOLVED FIXED

Status

Firefox OS
Gaia::System::Status bar, Utility tray, Notification
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wilsonpage, Assigned: wilsonpage)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 years ago
Created attachment 8621029 [details]
before.png
Attachment #8621029 - Flags: ui-review?(pabratowski)
Attachment #8621029 - Flags: review?(gmarty)
(Assignee)

Comment 1

3 years ago
Created attachment 8621030 [details]
after.png
(Assignee)

Updated

3 years ago
Summary: [quikc-settings] Icons aren't vertically aligned → [quick-settings] Icons aren't vertically aligned
(Assignee)

Comment 2

3 years ago
Created attachment 8621031 [details] [review]
pull-request (master)
Attachment #8621031 - Flags: review?(gmarty)
(Assignee)

Updated

3 years ago
Attachment #8621029 - Flags: ui-review?(pabratowski)
Attachment #8621029 - Flags: review?(gmarty)
(Assignee)

Updated

3 years ago
Attachment #8621030 - Flags: ui-review?(pabratowski)
Comment on attachment 8621031 [details] [review]
pull-request (master)

Flexbox FTW!
LGTM. Thanks!!

Just wait till you get a ui-r+ before landing.
Attachment #8621031 - Flags: review?(gmarty) → review+
(Assignee)

Updated

3 years ago
Assignee: nobody → wilsonpage
Status: NEW → ASSIGNED
Comment on attachment 8621031 [details] [review]
pull-request (master)

thanks Wilson
Attachment #8621031 - Flags: ui-review+
(Assignee)

Comment 5

3 years ago
LANDED https://github.com/mozilla-b2g/gaia/commit/26f74fb58e573616912ddbc11464f88e33afea63
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.