1173842 - Integrate trychooser for try pushes

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P4)

Description

[Martin Thomson [:mt:]]

I know that it's just a case of following a link, but when pushing to try it can be very useful.  Even framing it in would be better than what we have.  Communicating with postMessage would be a huge win though.

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1173842 - Embed trychooser into mozreview;

Review commit: https://reviewboard.mozilla.org/r/72532/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72532/

Comment 2

[Manish Goregaokar [:manishearth]]

Attachment: UI screenshot.png

Comment 3

[Manish Goregaokar [:manishearth]]

Right now I'm running the patch off localhost, but we'd need to update TRYCHOOSER_URL before landing once https://bugzilla.mozilla.org/show_bug.cgi?id=1295306 lands and is deployed.

Comment 4

[Manish Goregaokar [:manishearth]]

Comment on attachment 8782314 [details]
Bug 1173842 - Embed trychooser into mozreview;

https://reviewboard.mozilla.org/r/72532/#review70124

::: pylib/mozreview/mozreview/static/mozreview/js/autoland.js:6
(Diff revision 1)
>  $(document).on("mozreview_ready", function() {
>    // TODO: Stop hardcoding endpoint urls and provide them in a template.
>    var TRY_AUTOLAND_URL   = "/api/extensions/mozreview.extension.MozReviewExtension/try-autoland-triggers/";
>    var AUTOLAND_URL       = "/api/extensions/mozreview.extension.MozReviewExtension/autoland-triggers/";
>    var COMMIT_REWRITE_URL = "/api/extensions/mozreview.extension.MozReviewExtension/commit_rewrite/";
> +  var TRYCHOOSER_URL = "http://localhost:8000/?embed";

This is temporary, we shouldn't land until this gets updated.

Comment 5

[Steven MacLeod [:smacleod]]

Comment on attachment 8782314 [details]
Bug 1173842 - Embed trychooser into mozreview;

https://reviewboard.mozilla.org/r/72532/#review70124

> This is temporary, we shouldn't land until this gets updated.

Just to be clear, we'll need this URL to be configurable so that we can set some sort of mocking up in our test environment. Please don't embed the public url.

Comment 6

[Manish Goregaokar [:manishearth]]

Comment on attachment 8782314 [details]
Bug 1173842 - Embed trychooser into mozreview;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72532/diff/1-2/

Comment 7

[Manish Goregaokar [:manishearth]]

Comment on attachment 8782314 [details]
Bug 1173842 - Embed trychooser into mozreview;

https://reviewboard.mozilla.org/r/72532/#review70124

> Just to be clear, we'll need this URL to be configurable so that we can set some sort of mocking up in our test environment. Please don't embed the public url.

Fixed in the latest update. It can now be configured from the admin panel. The `<details>` element and iframe are only created if a trychooser url exists.

Comment 8

[David Walsh :davidwalsh]

Comment on attachment 8782314 [details]
Bug 1173842 - Embed trychooser into mozreview;

https://reviewboard.mozilla.org/r/72532/#review74444

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/eb9d44c48d3a
Embed trychooser into mozreview; r=davidwalsh

Comment 10

[Manish Goregaokar [:manishearth]]

Instructions for configuring:

 - bug 1295306 needs to have been deployed to `http://trychooser.pub.build.mozilla.org/`
 - For every repo that has try set up, there should be a new "Trychooser URL" field in the repo admin panel next to the try repo URL
 - Add `http://trychooser.pub.build.mozilla.org/?embed` to that field.

(ni?glob since AIUI you'll be doing the next deploy)

Comment 11

[Manish Goregaokar [:manishearth]]

In case trychooser can't be deployed, http://people.mozilla.org/~mgoregaokar/trychooser/?embed is a mirror of this version.

Comment 12

[:glob ✱]

i'll perform a mozreview deploy in about 16 hours from now.

Comment 13

[:glob ✱]

after a long delay due to sickness and deploy issue, this code is now live.

unfortunately trychooser isn't served using https, so we hit mixed content warnings.
i've filed bug 1302631 to hopefully get that fixed.

i'm not keen on using people.m.o to host production traffic, will see if there's a more suitable alternative host we can use in the short term until that bug is fixed.

Comment 14

[:glob ✱]

i've manually dropped trychooser on the mozreview webheads: https://reviewboard.mozilla.org/static/trychooser/

once bug 1302631 is resolved this will need to be removed (/data/www/reviewboard.mozilla.org/reviewboard/htdocs/static/trychooser on each webhead).