Closed Bug 1173864 Opened 5 years ago Closed 5 years ago

Make MarkStack private in GCMarker

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Now that PushMarkStack implementations are not static functions, we don't need external access to this anymore. This patch also adds some types to pushMarkStack, which caught us out in at least one lie.
Attachment #8621081 - Flags: review?(jcoppeard)
Comment on attachment 8621081 [details] [diff] [review]
gecko_typed_tracer_dispatch-v0.diff

Review of attachment 8621081 [details] [diff] [review]:
-----------------------------------------------------------------

I think you posted the wrong patch here - this one is already up in bug 1173889.
Attachment #8621081 - Flags: review?(jcoppeard)
Indeed! I appear to have clicked on the adjacent patch.
Attachment #8621081 - Attachment is obsolete: true
Attachment #8621641 - Flags: review?(jcoppeard)
Attachment #8621641 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/531cee33742c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.