make getText{At,After,Before}OffsetCB work with proxies

RESOLVED FIXED in Firefox 42

Status

()

Core
Disability Access APIs
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8621098 [details] [diff] [review]
make getText{At,After,Before}OffsetCB work with proxies
Attachment #8621098 - Flags: review?(lorien)

Comment 2

3 years ago
Comment on attachment 8621098 [details] [diff] [review]
make getText{At,After,Before}OffsetCB work with proxies

Review of attachment 8621098 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/atk/nsMaiInterfaceText.cpp
@@ +160,5 @@
>  getTextAfterOffsetCB(AtkText *aText, gint aOffset,
>                       AtkTextBoundary aBoundaryType,
>                       gint *aStartOffset, gint *aEndOffset)
>  {
> +    nsAutoString autoStr;

should be indented with 2 spaces not 4

@@ +172,5 @@
> +    text->TextAfterOffset(aOffset, aBoundaryType, &startOffset, &endOffset, autoStr);
> +    ConvertTexttoAsterisks(accWrap, autoStr);
> +  } else if (ProxyAccessible* proxy = GetProxy(ATK_OBJECT(aText))) {
> +    proxy->GetTextAfterOffset(aOffset, aBoundaryType, autoStr, &startOffset,
> +                              &endOffset);

not in the purview of this patch, but it seems pretty inconsistent that the arguments for GetText*Offset methods in ProxyAccessible are not in the same order as for AccessibleWraps
Attachment #8621098 - Flags: review?(lorien) → review+

Comment 3

3 years ago
Comment on attachment 8621098 [details] [diff] [review]
make getText{At,After,Before}OffsetCB work with proxies

Review of attachment 8621098 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/atk/nsMaiInterfaceText.cpp
@@ +200,5 @@
>      ConvertTexttoAsterisks(accWrap, autoStr);
> +  } else if (ProxyAccessible* proxy = GetProxy(ATK_OBJECT(aText))) {
> +    proxy->GetTextAtOffset(aOffset, aBoundaryType, autoStr, &startOffset,
> +                           &endOffset);
> +  }

Shouldn't we be calling ConvertTexttoAsterisks for proxies too?
I had to back this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/39e10fcfec80 for mn-e10s orange:

https://treeherder.mozilla.org/logviewer.html#?job_id=11672834&repo=mozilla-inbound
Flags: needinfo?(tbsaunde+mozbugs)
https://hg.mozilla.org/mozilla-central/rev/6dc447b14cd7
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Assignee: nobody → tbsaunde+mozbugs
(Assignee)

Updated

3 years ago
Flags: needinfo?(tbsaunde+mozbugs)
You need to log in before you can comment on or make changes to this bug.