[shipping] milestones view doesn't pick up milestone status

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox41 affected)

Details

(Assignee)

Description

3 years ago
I guess this is a regression from way back when I updated exhibit.

Right now, we always get the UI for new milestones, independent of status.

The suspect is that .status thinks it's a string, and is compared to numbers.

Should be easy to fix, likely by adding 

    "properties": {
        "status": {
            "valueType": "number"
            },
        }
(Assignee)

Updated

3 years ago
Priority: -- → P2

Comment 1

3 years ago
Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/6a1945ffd034b58af68d78fae16b0cd4e8778ff1
bug 1173989, exhibit sets can't tell apart 5 and "5". Use "5".

Filed https://github.com/simile-widgets/exhibit/issues/137 upstream on the
actual issue, but for now we're working around the problem by comparing
our status numbers to strings.
(Assignee)

Comment 2

3 years ago
Not hard to fix, but only an ugly fix was available.

See my check-in comment for details.

Marking FIXED, I'll deploy this on stage next.
Assignee: nobody → l10n
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.