Closed
Bug 117399
Opened 23 years ago
Closed 23 years ago
UMR of mModCount in nsEditor::IncrementModificationCount
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.8
People
(Reporter: jrgmorrison, Assigned: Brade)
References
Details
Attachments
(1 file)
515 bytes,
patch
|
glazou
:
review+
|
Details | Diff | Splinter Review |
Purify reports a UMR here, in nsEditor.cpp: NS_IMETHODIMP nsEditor::IncrementModificationCount(PRInt32 inNumMods) { PRUint32 oldModCount = mModCount; mModCount += inNumMods; if ((oldModCount == 0 && mModCount != 0) || (oldModCount != 0 && mModCount == 0)) NotifyDocumentListeners(eDocumentStateChanged); return NS_OK; } inNumMods is 1, but mModCount is 0xdeadbeef. Just need to initialize in the constructor, I suppose. (Note: it doesn't report the UMR for every call to IncrementModificationCount, only for (I guess) the initial call).
Assignee | ||
Comment 1•23 years ago
|
||
strange... I must have lost the initialization when preparing my patch.
Status: NEW → ASSIGNED
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → mozilla0.9.8
Assignee | ||
Comment 2•23 years ago
|
||
*** Bug 114578 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 3•23 years ago
|
||
Comment on attachment 63815 [details] [diff] [review] initialization in constructor r=glazman
Attachment #63815 -
Flags: review+
Assignee | ||
Comment 5•23 years ago
|
||
fix checked in (sr=kin after changing order to not cause warning on Linux)
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
I can verify that this is fixed, at least from my testcast in bug 114578, on Windows 2000 under Purify.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•