Closed Bug 1173998 Opened 4 years ago Closed 4 years ago

l10n partials aren't using l10n files for the previous mar

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Tracking Status
firefox41 --- fixed

People

(Reporter: mshal, Assigned: mshal)

Details

Attachments

(2 files)

When porting the partial mar generation into the tree, I didn't account for l10n builds. The "latestmar" definition always uses the en-US build instead of the localized version. I think we can just take the AB_CD value into account when listing the files.
nthomas noted that the latest_mar_dir in mozharness is also incorrect, and should end in "-l10n"
Attached patch latest-mar-l10nSplinter Review
Update the mozharness configs to use the -l10n dir to find the previous complete mar repacks
Attachment #8621700 - Flags: review?(nthomas)
Attached patch partial-mar-l10nSplinter Review
Change the grep to use ".locale.platform.complete.mar$" instead of just "platform.complete.mar$". Also change the rm to remove only the current locale's previous partial mar instead of all previous partial mars - this way we have all new partials after looping through the locales so that they can be uploaded to TC at the end.
Attachment #8621703 - Flags: review?(nthomas)
Attachment #8621700 - Flags: review?(nthomas) → review+
Attachment #8621703 - Flags: review?(nthomas) → review+
https://hg.mozilla.org/mozilla-central/rev/763336d4cbb2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8621703 [details] [diff] [review]
partial-mar-l10n

Approval Request Comment
[Feature/regressing bug #]: bug 1174241
[User impact if declined]: l10n builds on aurora are failing and using the incorrect previous complete mar
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]: none
Attachment #8621703 - Flags: approval-mozilla-aurora?
Comment on attachment 8621703 [details] [diff] [review]
partial-mar-l10n

This missed the uplift.
Attachment #8621703 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
The l10n automation for beta/release is different from central/aurora, so I'm not sure if we need this for beta. From what I can tell from the beta repack logs, this code is unused. It shouldn't hurt anything to uplift, though :).
Comment on attachment 8621703 [details] [diff] [review]
partial-mar-l10n

AFAIK we do not need this code for Beta 40. Please renom if this is incorrect or changes. Beta-
Attachment #8621703 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.