1173998 - l10n partials aren't using l10n files for the previous mar

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Michael Shal [:mshal]]

When porting the partial mar generation into the tree, I didn't account for l10n builds. The "latestmar" definition always uses the en-US build instead of the localized version. I think we can just take the AB_CD value into account when listing the files.

Comment 1

[Michael Shal [:mshal]]

nthomas noted that the latest_mar_dir in mozharness is also incorrect, and should end in "-l10n"

Comment 2

[Michael Shal [:mshal]]

Attachment: latest-mar-l10n

Update the mozharness configs to use the -l10n dir to find the previous complete mar repacks

Comment 3

[Michael Shal [:mshal]]

Attachment: partial-mar-l10n

Change the grep to use ".locale.platform.complete.mar$" instead of just "platform.complete.mar$". Also change the rm to remove only the current locale's previous partial mar instead of all previous partial mars - this way we have all new partials after looping through the locales so that they can be uploaded to TC at the end.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/763336d4cbb2

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8621700 [details] [diff] [review]
latest-mar-l10n

https://hg.mozilla.org/build/mozharness/rev/f0d04c716c93

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/763336d4cbb2

Comment 7

[Michael Shal [:mshal]]

Comment on attachment 8621703 [details] [diff] [review]
partial-mar-l10n

Approval Request Comment
[Feature/regressing bug #]: bug 1174241
[User impact if declined]: l10n builds on aurora are failing and using the incorrect previous complete mar
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8621703 [details] [diff] [review]
partial-mar-l10n

This missed the uplift.

Comment 9

[Michael Shal [:mshal]]

The l10n automation for beta/release is different from central/aurora, so I'm not sure if we need this for beta. From what I can tell from the beta repack logs, this code is unused. It shouldn't hurt anything to uplift, though :).

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8621703 [details] [diff] [review]
partial-mar-l10n

AFAIK we do not need this code for Beta 40. Please renom if this is incorrect or changes. Beta-