Closed Bug 1174064 Opened 9 years ago Closed 9 years ago

[EME] GMPs doing async shutdown can be reused

Categories

(Core :: Audio/Video, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox39 --- fixed
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

If you refresh a tab that automatically loads a GMP and that GMP supports async shutdown, the GMP will start async shutdown but the new tab (since it's same origin) will try to reuse the same GMP process, and we'll end up reusing the GMP after it's been told to shutdown.
Check the "are we doing async shutdown" flag in the places where we decide whether we can reuse a GMP, so we don't try to reuse a dying GMP.
Attachment #8621441 - Flags: review?(edwin)
https://hg.mozilla.org/mozilla-central/rev/bd9902d39e75
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment on attachment 8621441 [details] [diff] [review]
Patch: Don't allow GMPs shutting down to be reused

Approval Request Comment
[Feature/regressing bug #]: EME

[User impact if declined]: Without this path, on a page using EME, if the user refreshes/reloads the page, we could end up starting the EME Plugin shutdown sequence but then re-using the same plugin for the after-refresh page as the before-refresh page. That is, we can tell the EME Plugin we're shutting it down, but not actually shut it down. This can get the EME Plugin into an inconsistent state, it breaks the logic to track how far through playback the video was.

[Describe test coverage new/current, TreeHerder]: We have lots of tests to cover EME.

[Risks and why]: Pretty low; this changes our "should we re-use this plugin instance or create a new one?" logic take the "create a new one" path more often. Both paths are well tested.

[String/UUID change made/needed]: None.
Attachment #8621441 - Flags: approval-mozilla-beta?
Attachment #8621441 - Flags: approval-mozilla-aurora?
Comment on attachment 8621441 [details] [diff] [review]
Patch: Don't allow GMPs shutting down to be reused

Approved for uplift to aurora and beta.
Attachment #8621441 - Flags: approval-mozilla-beta?
Attachment #8621441 - Flags: approval-mozilla-beta+
Attachment #8621441 - Flags: approval-mozilla-aurora?
Attachment #8621441 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.