1174082 - Fix minor indentation problems in perfherder

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[MikeLing]

Some code style problem for bug-1169340 need to be fixed, most of them is js code should indented 4 spaces, not 2. Detail information could be checked in here https://github.com/mozilla/treeherder/pull/588 :)

Comment 1

[MikeLing]

Hi Will,

I'm wondering the jfrench's suggestions in there. Should I change the error message and the "has-error" condition in my pr or simply fix the indentation problem?

Thank you:)

Comment 2

[William Lachance (:wlach)]

Hi Mike, sure, you can fix other problems in the same commit / PR. Just rename this bug to something like "Fix minor style and whitespace issues in Perfherder" and give your commit / PR a similar title. Thanks!

Comment 3

[MikeLing]

Attachment: patch for bug1174082 fixing

I had update my PR for this issue. Due to Will has create a new bug for the 'error message issue', I would like to create a new PR for that and ask review in it :)

Thank you

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/7c1a49c498312359b1ad760d9a02dd706988d313
Bug 1174082-Fix minor indentation problems in perfherder

Comment 5

[William Lachance (:wlach)]

Landed the patch!