1174106 - A test bug to test review board

Status: RESOLVED INVALID

(Invalid Bugs :: General, defect)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1174106. Part 1. r?jwwang

Bug 1174106 - A test bug to test review board. r?jw_wang

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8621527 [details]
MozReview Request: Bug 1174106. Part 1. r?jwwang

Bug 1174106 - A test bug to test review board. r?jw_wang

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8621527 [details]
MozReview Request: Bug 1174106. Part 1. r?jwwang

later.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8621527 [details]
MozReview Request: Bug 1174106. Part 1. r?jwwang

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/10999/diff/2-3/

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1174106. Part 1-3. r?jwwang

Bug 1174106. Part 2.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8621527 [details]
MozReview Request: Bug 1174106. Part 1. r?jwwang

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/10999/diff/3-4/

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1174106. Part 2. r?jwwang

Bug 1174106. Part 1-2. r?jwwang

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8690783 [details]
MozReview Request: Bug 1174106. Part 1-3. r?jwwang

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25949/diff/1-2/

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8621527 [details]
MozReview Request: Bug 1174106. Part 1. r?jwwang

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/10999/diff/4-5/

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8690784 [details]
MozReview Request: Bug 1174106. Part 2. r?jwwang

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25951/diff/1-2/

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8690783 [details]
MozReview Request: Bug 1174106. Part 1-3. r?jwwang

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25949/diff/2-3/

Comment 12

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1174106. Part 2. r?jwwang

Bug 1174106. Part 2. r?jwwang

Comment 13

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8621527 [details]
MozReview Request: Bug 1174106. Part 1. r?jwwang

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/10999/diff/5-6/

Comment 14

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8690784 [details]
MozReview Request: Bug 1174106. Part 2. r?jwwang

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25951/diff/2-3/

Comment 15

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1174106. part 1-2. r?jwwang

Bug 1174106. part 1-2. r?jwwang

Comment 16

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8690784 [details]
MozReview Request: Bug 1174106. Part 2. r?jwwang

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25951/diff/3-4/

Comment 17

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1174106. Part 1-3. r?jwwang

Bug 1174106. Part 1-3. r?jwwang

Comment 18

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8690784 [details]
MozReview Request: Bug 1174106. Part 2. r?jwwang

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25951/diff/4-5/

Comment 19

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8621527 [details]
MozReview Request: Bug 1174106. Part 1. r?jwwang

https://reviewboard.mozilla.org/r/10999/#review23663

LGTM.

Comment 20

[JW Wang [:jwwang] [:jw_wang]]

https://reviewboard.mozilla.org/r/10999/#review23665

LGTM2.

Comment 21

[Tzuhao Kuo [:kaku]]

Comment on attachment 8621527 [details]
MozReview Request: Bug 1174106. Part 1. r?jwwang

https://reviewboard.mozilla.org/r/10999/#review23667

Comment 22

[Tzuhao Kuo [:kaku]]

Comment on attachment 8621527 [details]
MozReview Request: Bug 1174106. Part 1. r?jwwang

https://reviewboard.mozilla.org/r/10999/#review23669

Comment 23

[Tzuhao Kuo [:kaku]]

Comment on attachment 8621527 [details]
MozReview Request: Bug 1174106. Part 1. r?jwwang

https://reviewboard.mozilla.org/r/10999/#review23671

r=me.

Comment 24

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8621527 [details]
MozReview Request: Bug 1174106. Part 1. r?jwwang

https://reviewboard.mozilla.org/r/10999/#review23673

no r+???

Comment 25

[Ben Hsu [:HoPang]]

Attachment: Bug 1174106 - Part 1: Add useCache to RegistrationOptions(WebIDL);

r=rchien

Review commit: https://reviewboard.mozilla.org/r/91914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91914/

Comment 26

[Ben Hsu [:HoPang]]

Attachment: Bug 1174106 - Part 2: Load the top level SW script with http cache bypass settings;

bypass settings. r=rchien

Review commit: https://reviewboard.mozilla.org/r/91916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91916/

Comment 27

[Ben Hsu [:HoPang]]

Attachment: Bug 1174106 - Part 3: ImportScripts() in SW should use the same http cache bypass settings as its top level SW script;

cache bypass settings as its top level SW script. r=rchien

Review commit: https://reviewboard.mozilla.org/r/91918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91918/

Comment 28

[Ben Hsu [:HoPang]]

Attachment: Bug 1174106 - Part 4: Update an existing testcase;

Review commit: https://reviewboard.mozilla.org/r/91920/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91920/

Comment 29

[Ben Hsu [:HoPang]]

Comment on attachment 8809322 [details]
Bug 1174106 - Part 1: Add useCache to RegistrationOptions(WebIDL);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91914/diff/1-2/

Comment 30

[Ben Hsu [:HoPang]]

Comment on attachment 8809323 [details]
Bug 1174106 - Part 2: Load the top level SW script with http cache bypass settings;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91916/diff/1-2/

Comment 31

[Ben Hsu [:HoPang]]

Comment on attachment 8809324 [details]
Bug 1174106 - Part 3: ImportScripts() in SW should use the same http cache bypass settings as its top level SW script;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91918/diff/1-2/

Comment 32

[Ben Hsu [:HoPang]]

Comment on attachment 8809325 [details]
Bug 1174106 - Part 4: Update an existing testcase;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91920/diff/1-2/

Comment 33

[Ben Hsu [:HoPang]]

Comment on attachment 8809322 [details]
Bug 1174106 - Part 1: Add useCache to RegistrationOptions(WebIDL);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91914/diff/2-3/

Comment 34

[Ben Hsu [:HoPang]]

Comment on attachment 8809323 [details]
Bug 1174106 - Part 2: Load the top level SW script with http cache bypass settings;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91916/diff/2-3/

Comment 35

[Ben Hsu [:HoPang]]

Comment on attachment 8809324 [details]
Bug 1174106 - Part 3: ImportScripts() in SW should use the same http cache bypass settings as its top level SW script;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91918/diff/2-3/

Comment 36

[Ben Hsu [:HoPang]]

Comment on attachment 8809325 [details]
Bug 1174106 - Part 4: Update an existing testcase;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91920/diff/2-3/

Comment 37

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8809322 [details]
Bug 1174106 - Part 1: Add useCache to RegistrationOptions(WebIDL);

https://reviewboard.mozilla.org/r/91914/#review91874

Comment 38

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8809322 [details]
Bug 1174106 - Part 1: Add useCache to RegistrationOptions(WebIDL);

https://reviewboard.mozilla.org/r/91914/#review91876

Comment 39

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8809323 [details]
Bug 1174106 - Part 2: Load the top level SW script with http cache bypass settings;

https://reviewboard.mozilla.org/r/91916/#review91878

Comment 40

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8809324 [details]
Bug 1174106 - Part 3: ImportScripts() in SW should use the same http cache bypass settings as its top level SW script;

https://reviewboard.mozilla.org/r/91918/#review91882

Comment 41

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8809325 [details]
Bug 1174106 - Part 4: Update an existing testcase;

https://reviewboard.mozilla.org/r/91920/#review91884