1174111 - |test_sendTimeout| in test_TelemetryControllerShutdown.js must not wait on ping submission

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Alessio Placitelli [:Dexter]]

In |test_sendTimeout| (test_TelemetryControllerShutdown.js) [1] we wait on the ping submission before triggering the phase change/shutdown.

This makes the test take a lot of time and possibly never fail. We should be waiting on the submission promise after the AsyncShutdown phases are manually triggered.

[1] - https://hg.mozilla.org/mozilla-central/annotate/8cf9d3e497f9/toolkit/components/telemetry/tests/unit/test_TelemetryControllerShutdown.js#l64

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: bug1174111.patch

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8621509 [details] [diff] [review]
bug1174111.patch

Review of attachment 8621509 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/tests/unit/test_TelemetryControllerShutdown.js
@@ +65,5 @@
>  
>    // Trigger the AsyncShutdown phase TelemetryController hangs off.
>    AsyncShutdown.profileBeforeChange._trigger();
>    AsyncShutdown.sendTelemetry._trigger();
> +  yield submissionPromise;

Nit: Lets put a new comment before that like "Now wait for the ping submission."

Comment 3

[Alessio Placitelli [:Dexter]]

Attachment: bug1174111.patch - v2

Thanks Georg. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=efc5c1c0cca5

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6048df01bf47

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6048df01bf47