Closed Bug 1174227 Opened 9 years ago Closed 9 years ago

When you clear the history (clear private data), the favicons in the bookmark list aren't fetched until you click the link

Categories

(Firefox for iOS :: Favicons, defect)

ARM
iOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1161630
Tracking Status
fxios + ---

People

(Reporter: bmunar, Unassigned)

References

Details

(Keywords: reproducible)

Attachments

(1 file)

47 bytes, text/x-github-pull-request
Details | Review
1. bookmark a bunch of pages
2. go to settings and clear private data
3. check the bookmark tab in the home screen and the favicons aren't there!
Favicons – the hardest problem in computer science
Keywords: reproducible
Hardware: Other → ARM
Did your favicon cleanup fix this, Wes?
Flags: needinfo?(wjohnston)
HistoryClearable Confuse.

I found that this bug is caused by clear history when clear private. Currently, when clear history, the client will clear the favicons together. (See it in https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Settings/Clearables.swift#L36 after comment this 3 lines out the bug fixed). So the question is, should we clear favicons when clear browser history record? If the answer is no, then when we should clear the favicons? IMHO, I think add a alertaction in the setting tableview to clear favorite sites is a good solution?
See dep.
Depends on: 1161630
Attached file Pull request
Attachment #8630284 - Flags: review?(rnewman)
I'm going to close this a dupe since I have a pretty-much-done patch for it in the other bug. Sorry :( But thanks for the patch.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(wjohnston)
Resolution: --- → DUPLICATE
(In reply to Wesley Johnston (:wesj) from comment #6)
> I'm going to close this a dupe since I have a pretty-much-done patch for it
> in the other bug. Sorry :( But thanks for the patch.
> 
> *** This bug has been marked as a duplicate of bug 1161630 ***

Okay. You're welcome.
Attachment #8630284 - Flags: review?(rnewman)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: