Closed
Bug 1174256
Opened 9 years ago
Closed 9 years ago
Autoland should retry pushes if a tree is closed
Categories
(Conduit Graveyard :: Transplant, defect)
Conduit Graveyard
Transplant
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dminor, Assigned: dminor)
Details
Attachments
(1 file)
If a push to a tree fails due to tree closure, the push attempt should be retried rather than marked as a failure. It would also make sense to add a check to tree status before attempting any pushes to a tree to avoid making a bunch of pushes that will end up failing.
Comment 1•9 years ago
|
||
This sounds like a use case for the event table in MozReview (Autoland could update MozReview saying it attempted to land but the tree was close, will retry later, etc.)
Assignee | ||
Comment 2•9 years ago
|
||
autoland: retry autoland requests if the destination tree is closed (bug 1174256) r=mdoglio This adds code to check tree status and not attempt to push to a tree if it is reported as closed. We also add a check for 'is CLOSED' in the response from the mercurial server and will not update the status of the autoland request in that case so that it will be retried next time.
Attachment #8621794 -
Flags: review?(mdoglio)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Comment 3•9 years ago
|
||
Comment on attachment 8621794 [details] MozReview Request: autoland: retry autoland requests if the destination tree is closed (bug 1174256) r=mdoglio https://reviewboard.mozilla.org/r/11055/#review9731 ::: autoland/autoland/treestatus.py:11 (Diff revision 1) > + return json.loads(r.text)['status'] == 'open' You can use r.json() directly here
Attachment #8621794 -
Flags: review?(mdoglio)
Comment 4•9 years ago
|
||
Comment on attachment 8621794 [details] MozReview Request: autoland: retry autoland requests if the destination tree is closed (bug 1174256) r=mdoglio https://reviewboard.mozilla.org/r/11055/#review9733 Ship It!
Attachment #8621794 -
Flags: review+
Assignee | ||
Comment 5•9 years ago
|
||
Thanks, pushed to: https://hg.mozilla.org/hgcustom/version-control-tools/rev/ef0bddc481c7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Tree Management → MozReview
Updated•6 years ago
|
Product: MozReview → Conduit
Updated•28 days ago
|
Product: Conduit → Conduit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•