1174256 - Autoland should retry pushes if a tree is closed

Status: RESOLVED FIXED

(Conduit Graveyard :: Transplant, defect)

Description

[Dan Minor [:dminor]]

If a push to a tree fails due to tree closure, the push attempt should be retried rather than marked as a failure.

It would also make sense to add a check to tree status before attempting any pushes to a tree to avoid making a bunch of pushes that will end up failing.

Comment 1

[Steven MacLeod [:smacleod]]

This sounds like a use case for the event table in MozReview (Autoland could update MozReview saying it attempted to land but the tree was close, will retry later, etc.)

Comment 2

[Dan Minor [:dminor]]

Attachment: MozReview Request: autoland: retry autoland requests if the destination tree is closed (bug 1174256) r=mdoglio

autoland: retry autoland requests if the destination tree is closed (bug 1174256) r=mdoglio

This adds code to check tree status and not attempt to push to a tree if it is
reported as closed. We also add a check for 'is CLOSED' in the response from
the mercurial server and will not update the status of the autoland request in
that case so that it will be retried next time.

Comment 3

[Mauro Doglio [:mdoglio]]

Comment on attachment 8621794 [details]
MozReview Request: autoland: retry autoland requests if the destination tree is closed (bug 1174256) r=mdoglio

https://reviewboard.mozilla.org/r/11055/#review9731

::: autoland/autoland/treestatus.py:11
(Diff revision 1)
> +            return json.loads(r.text)['status'] == 'open'

You can use r.json() directly here

Comment 4

[Mauro Doglio [:mdoglio]]

Comment on attachment 8621794 [details]
MozReview Request: autoland: retry autoland requests if the destination tree is closed (bug 1174256) r=mdoglio

https://reviewboard.mozilla.org/r/11055/#review9733

Ship It!

Comment 5

[Dan Minor [:dminor]]

Thanks, pushed to: https://hg.mozilla.org/hgcustom/version-control-tools/rev/ef0bddc481c7