1174259 - Zoom should reset when clicking on graph

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

The zoom on the graph should reset to default when you click on the graph view. Right now it stays zoomed in if you have zoomed in, which is counter-intuitive.

I haven't looked into exactly what should change, but I think this should be relatively simple. It looks like there's a plotunselected method in flot we can bind to which we use in graphs.mozilla.org to get the same effect:

http://hg.mozilla.org/graphs/file/c06641fd7680/js/graph-2.js#l58

Here's the current code to handle the plotselect method. The code you add should be around here:

https://github.com/mozilla/treeherder/blob/master/ui/js/graphs.js#L246

Comment 1

[Akhilesh Pillai]

I have a fix for this, I am assuming clicking on graph view implies clicking on #overview-plot element. Will send out a patch as pull request, however just an FYI this is how I am doing this. 

$("#overview-plot").bind("plotunselected",function(event,ranges) {
        $scope.zoom = {};
        deselectDataPoint();
        updateDocument();
        // refetch and re-render all graph data
        $q.all($scope.seriesList.map(getSeriesData)).then(function() {
          plotGraph();
        });
        console.log("in plotunselected overview");
});

Comment 2

[Akhilesh Pillai]

Attachment: Fix for Bug 1174259

Hi Will,

Please let me know if I need a new pull req for this.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8627173 [details] [review]
Fix for  Bug 1174259

Very close, just need to drop one unwanted commit from the PR and make a minor adjustment.

Comment 4

[Akhilesh Pillai]

Attachment: FIx for bug 1174259

Hi Will,
Thanks for earlier reviews. Please have a look modified this one as per your suggestion. 

Thanks
-Akhilesh

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8629786 [details] [review]
FIx for bug 1174259

So close. Just fix the indentation problem that jfrench pointed out in the PR and then re-raise r? ? :)

Comment 6

[Akhilesh Pillai]

Comment on attachment 8629786 [details] [review]
FIx for bug 1174259

Corrected the indentation problem. Please have a look.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/99772982a128ed04263a001b26d0097065c3032b
Bug 1174259 - Zoom should reset when clicking on graph

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8629786 [details] [review]
FIx for bug 1174259

This works, thank you!