Closed
Bug 1174285
Opened 9 years ago
Closed 6 years ago
Misc cleanups needed
Categories
(Firefox OS Graveyard :: Gaia::P2P Sharing, defect, P2)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: drs, Unassigned)
Details
12:41 drs: justindarc: retroactive review? https://github.com/fxos/sharing/commit/275e1e8146bdf875c58aab3fe17e0e170fcca813 12:41 marcia has joined (chatzilla@moz-udck92.ujol.1ibb.0101.2620.IP) 12:41 justindarc: drs: ha.. let me see 12:43 justindarc: drs: the toggle() code looks a little shakey because of e.target, but, otherwise LGTM 12:44 pdahiya is now known as pdahiya| 12:44 drs: justindarc: yeah, maybe I should make it check for `closest('li')` or something and use that as the root 12:44 pdahiya| is now known as pdahiya|brb 12:45 justindarc: drs: yeah.. also you're doing the querySelector('.control') twice instead of caching the result 12:45 justindarc: drs: i mean, its fine.. i'm sure it works 12:45 justindarc: drs: at this point though, its acceptable 12:46 drs: yeah, the Sharing app needs cleanups everywhere. I'll file a bug for these
Reporter | ||
Comment 1•9 years ago
|
||
Triagr automatic comment: didn't know what to do when triaging.
Reporter | ||
Comment 2•9 years ago
|
||
Triagr automatic comment: didn't know what to do when triaging.
Comment 3•6 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•