1174334 - Missing option_collection of a job breaks the complete view of a changeset

Status: RESOLVED DUPLICATE of bug 1043338

(Tree Management :: Treeherder: API, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When sending a report to treeherder and the job does not contain a option_collection (as added via add_option_collection()), the whole web view will be broken.

Here you can see the traceback:

{"traceback": "Traceback (most recent call last):\n File \"/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/views.py\", line 400, in dispatch\n response = handler(request, *args, **kwargs)\n File \"/home/vagrant/treeherder/treeherder/webapp/api/utils.py\", line 200, in use_jobs_model\n return model_func(*args, jm=jm, **kwargs)\n File \"/home/vagrant/treeherder/treeherder/webapp/api/jobs.py\", line 80, in list\n job[\"platform_option\"] = get_option(job, option_collections)\n File \"/home/vagrant/treeherder/treeherder/webapp/api/utils.py\", line 209, in get_option\n return option_collections[opt]['opt']\nKeyError: u'da39a3ee5e6b4b0d3255bfef95601890afd80709'\n", "detail": "u'da39a3ee5e6b4b0d3255bfef95601890afd80709'"}

We should check if an option collection is set, and fail if not. Or make a sane default value.

Comment 1

[Cameron Dawson [:camd]]

Seems like we should default to just ``opt`` if we don't see an option collection.  Or, like Henrik says, just fail on submission.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So this is limited to the view of a full changeset not everything. Updating summary accordingly.