1174351 - Report Abuse should be a link and not a button

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://marketplace-altdev.allizom.org/website/484
2. Notice the Report Abuse link

expected behavior:
Report Abuse form is a link

actual behavior:
Report Abuse form is a button

screenshot: https://www.dropbox.com/s/ozn8pj6nljrzqjk/Screenshot%202015-06-10%2012.57.41.png?dl=0

Comment 1

[Zunaid Amin Enan]

Umm do u mind giving me the report abuse link? cant find it :/

Comment 2

[Zunaid Amin Enan]

So how can i fix this bug? help :/

Comment 3

[Tyler Steiman]

(In reply to krupa raj[:krupa] from comment #0)
> steps to reproduce:
> 1. Load https://marketplace-altdev.allizom.org/website/484
> 2. Notice the Report Abuse link
> 
> expected behavior:
> Report Abuse form is a link
> 
> actual behavior:
> Report Abuse form is a button
> 
> screenshot:
> https://www.dropbox.com/s/ozn8pj6nljrzqjk/Screenshot%202015-06-10%2012.57.41.
> png?dl=0

Is the problem with the "Report an issue" button, because there's also a link stating "Report Trademark Abuse". The description should probably be a little clearer concerning this, as I'm not seeing a "Report Abuse" button.

Comment 4

[Atique Ahmed Ziad [:atiqueahmedziad]]

Yes, the problem is with "Report an issue" button. And "Report an issue" would be a link, not a button.

Comment 5

[Shivee Gupta]

Is the following link OK in place of the button ?
https://www.dropbox.com/s/zv3rbri14fyheij/patch.png?dl=0

Comment 6

[Atique Ahmed Ziad [:atiqueahmedziad]]

Looks okey. Now we need to add font-weight to the link. Can you please add a font weight of 500 to the link ?

Comment 7

[Atique Ahmed Ziad [:atiqueahmedziad]]

If you are done, then send a pull request for review. 
 
And if you need any help, please ask

Comment 8

[Atique Ahmed Ziad [:atiqueahmedziad]]

This is belongs to the Front-end part i.e. Fireplace (https://github.com/mozilla/fireplace) 

You may want to look at this file - https://github.com/mozilla/fireplace/blob/master/src/templates/website/index.html 

Please ask, if you have any more question :)

Comment 9

[Shivee Gupta]

(In reply to Atique Ahmed Ziad [:atiqueahmedziad] from comment #7)
> If you are done, then send a pull request for review. 
>  
> And if you need any help, please ask

https://www.dropbox.com/s/hknxrvnaepvmt8b/patch2.png?dl=0
does that font weight look alright ?

Also i tried searching for the source code of this page but unable to find it. Any idea where to look ?

Comment 10

[Atique Ahmed Ziad [:atiqueahmedziad]]

Maybe, if you set 500 :) 

Here is the html file - https://github.com/mozilla/fireplace/blob/master/src/templates/website/index.html 

css file- https://github.com/mozilla/fireplace/blob/master/src/media/css/detail/base.styl

You may want to use the selector .website-report-issue a { your styles }

Comment 11

[Shivee Gupta]

Attachment: pr for button to link and font weight

Comment 12

[Atique Ahmed Ziad [:atiqueahmedziad]]

Comment on attachment 8623072 [details] [diff] [review]
pr for button to link and font weight

You need to send pull request to https://github.com/mozilla/fireplace 
You had sent pr in your fork repo. 
More I dont think think you need to delete any css. Just add font-weight: 500 on that selector

Comment 13

[Shivee Gupta]

Attachment: pr for bug 1174351

Comment 14

[Atique Ahmed Ziad [:atiqueahmedziad]]

here you can see a font-weight is  (In reply to Shivee Gupta from comment #13)
> Created attachment 8623536 [details] [review]
> pr for bug 1174351

Your branch is not updated with the latest Fireplace Master branch. Yesterday, a commit of mine was merged there. You may want to close this pr & update your repo & then send a pull request :) 

And some suggestion for your next pr :
https://github.com/mozilla/fireplace/blob/master/src/media/css/detail/base.styl#L50

As you can here already font-weight is given to a.website-detail--category-link So we don't need to call another class separately anywhere. You can just edit that line like :
.website-detail--category-link, .website-report-issue a { your styles }

And you have deleted the class from html file. But you may have forget to delete a white space there. Removing that would be nice. 

Let me know if you have any questions :)

Comment 15

[Atique Ahmed Ziad [:atiqueahmedziad]]

Also please include the bug id in commit title

Comment 16

[Shivee Gupta]

Attachment: pr with mentioned changes

Comment 17

[Atique Ahmed Ziad [:atiqueahmedziad]]

(In reply to Atique Ahmed Ziad [:atiqueahmedziad] from comment #15)
> Also please include the bug id in commit title

As i told in that comment, please include the bug number on commit title & pr title :)

Comment 18

[Shivee Gupta]

(In reply to Atique Ahmed Ziad [:atiqueahmedziad] from comment #17)
> (In reply to Atique Ahmed Ziad [:atiqueahmedziad] from comment #15)
> > Also please include the bug id in commit title
> 
> As i told in that comment, please include the bug number on commit title &
> pr title :)

done

Comment 19

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/fireplace/commit/3391f896fecf18777daa51136911a70d25ed6728

Comment 20

[Madalin Cotetiu]

Verified as fixed in marketplace-dev
The report an issue is now a link: http://screencast.com/t/nzwQytBdX0Mo
Closing bug: