Closed
Bug 1174351
Opened 9 years ago
Closed 9 years ago
Report Abuse should be a link and not a button
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: krupa.mozbugs, Assigned: shiveegpt77, Mentored)
References
()
Details
(Whiteboard: [good first bug][lang=css][lang=html])
Attachments
(3 files)
steps to reproduce: 1. Load https://marketplace-altdev.allizom.org/website/484 2. Notice the Report Abuse link expected behavior: Report Abuse form is a link actual behavior: Report Abuse form is a button screenshot: https://www.dropbox.com/s/ozn8pj6nljrzqjk/Screenshot%202015-06-10%2012.57.41.png?dl=0
Comment 1•9 years ago
|
||
Umm do u mind giving me the report abuse link? cant find it :/
Updated•9 years ago
|
Mentor: softfilebd
Whiteboard: [good first bug][lang=css][lang=html]
Comment 2•9 years ago
|
||
So how can i fix this bug? help :/
Comment 3•9 years ago
|
||
(In reply to krupa raj[:krupa] from comment #0) > steps to reproduce: > 1. Load https://marketplace-altdev.allizom.org/website/484 > 2. Notice the Report Abuse link > > expected behavior: > Report Abuse form is a link > > actual behavior: > Report Abuse form is a button > > screenshot: > https://www.dropbox.com/s/ozn8pj6nljrzqjk/Screenshot%202015-06-10%2012.57.41. > png?dl=0 Is the problem with the "Report an issue" button, because there's also a link stating "Report Trademark Abuse". The description should probably be a little clearer concerning this, as I'm not seeing a "Report Abuse" button.
Flags: needinfo?(krupa.mozbugs)
Comment 4•9 years ago
|
||
Yes, the problem is with "Report an issue" button. And "Report an issue" would be a link, not a button.
Flags: needinfo?(krupa.mozbugs)
Assignee | ||
Comment 5•9 years ago
|
||
Is the following link OK in place of the button ? https://www.dropbox.com/s/zv3rbri14fyheij/patch.png?dl=0
Comment 6•9 years ago
|
||
Looks okey. Now we need to add font-weight to the link. Can you please add a font weight of 500 to the link ?
Comment 7•9 years ago
|
||
If you are done, then send a pull request for review. And if you need any help, please ask
Comment 8•9 years ago
|
||
This is belongs to the Front-end part i.e. Fireplace (https://github.com/mozilla/fireplace) You may want to look at this file - https://github.com/mozilla/fireplace/blob/master/src/templates/website/index.html Please ask, if you have any more question :)
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to Atique Ahmed Ziad [:atiqueahmedziad] from comment #7) > If you are done, then send a pull request for review. > > And if you need any help, please ask https://www.dropbox.com/s/hknxrvnaepvmt8b/patch2.png?dl=0 does that font weight look alright ? Also i tried searching for the source code of this page but unable to find it. Any idea where to look ?
Comment 10•9 years ago
|
||
Maybe, if you set 500 :) Here is the html file - https://github.com/mozilla/fireplace/blob/master/src/templates/website/index.html css file- https://github.com/mozilla/fireplace/blob/master/src/media/css/detail/base.styl You may want to use the selector .website-report-issue a { your styles }
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8623072 -
Flags: review?(softfilebd)
Comment 12•9 years ago
|
||
Comment on attachment 8623072 [details] [diff] [review] pr for button to link and font weight You need to send pull request to https://github.com/mozilla/fireplace You had sent pr in your fork repo. More I dont think think you need to delete any css. Just add font-weight: 500 on that selector
Attachment #8623072 -
Flags: review?(softfilebd) → review-
Updated•9 years ago
|
Priority: -- → P3
Updated•9 years ago
|
Assignee: nobody → shiveegpt77
Assignee | ||
Comment 13•9 years ago
|
||
Attachment #8623536 -
Flags: review?(softfilebd)
Comment 14•9 years ago
|
||
here you can see a font-weight is (In reply to Shivee Gupta from comment #13) > Created attachment 8623536 [details] [review] > pr for bug 1174351 Your branch is not updated with the latest Fireplace Master branch. Yesterday, a commit of mine was merged there. You may want to close this pr & update your repo & then send a pull request :) And some suggestion for your next pr : https://github.com/mozilla/fireplace/blob/master/src/media/css/detail/base.styl#L50 As you can here already font-weight is given to a.website-detail--category-link So we don't need to call another class separately anywhere. You can just edit that line like : .website-detail--category-link, .website-report-issue a { your styles } And you have deleted the class from html file. But you may have forget to delete a white space there. Removing that would be nice. Let me know if you have any questions :)
Comment 15•9 years ago
|
||
Also please include the bug id in commit title
Updated•9 years ago
|
Attachment #8623536 -
Flags: review?(softfilebd) → review-
Assignee | ||
Comment 16•9 years ago
|
||
Attachment #8623658 -
Flags: review?(softfilebd)
Comment 17•9 years ago
|
||
(In reply to Atique Ahmed Ziad [:atiqueahmedziad] from comment #15) > Also please include the bug id in commit title As i told in that comment, please include the bug number on commit title & pr title :)
Assignee | ||
Comment 18•9 years ago
|
||
(In reply to Atique Ahmed Ziad [:atiqueahmedziad] from comment #17) > (In reply to Atique Ahmed Ziad [:atiqueahmedziad] from comment #15) > > Also please include the bug id in commit title > > As i told in that comment, please include the bug number on commit title & > pr title :) done
Comment 19•9 years ago
|
||
https://github.com/mozilla/fireplace/commit/3391f896fecf18777daa51136911a70d25ed6728
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Attachment #8623658 -
Flags: review?(softfilebd) → review+
Comment 20•9 years ago
|
||
Verified as fixed in marketplace-dev The report an issue is now a link: http://screencast.com/t/nzwQytBdX0Mo Closing bug:
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•