Closed Bug 1174356 Opened 5 years ago Closed 5 years ago

forward declare mozilla::MediaRawData in mp4_demuxer/Index.h

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch Fix (obsolete) — Splinter Review
Hit this trying to hook up a gtest for MP4Metadata.
Attachment #8621895 - Flags: review?(jyavenard)
Blocks: 1161350
Comment on attachment 8621895 [details] [diff] [review]
Fix

Review of attachment 8621895 [details] [diff] [review]:
-----------------------------------------------------------------

MediaRawData is returned by GetNext()

I don't like to use forward declaration in that case. 
To me a function declared in a header must be wholly contained in that header for both the declaration and the object returned.  

Here the user of Index.h will also have to do #include MediaData.h in order to use GetNext()

So instead I would include MediaData.h
Attachment #8621895 - Flags: review?(jyavenard) → review-
Attached patch fix v2Splinter Review
Thanks for the review. This better?
Attachment #8621895 - Attachment is obsolete: true
Attachment #8622521 - Flags: review?(jyavenard)
Attachment #8622521 - Flags: review?(jyavenard) → review+
https://hg.mozilla.org/mozilla-central/rev/26804dc7a709
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.