1174356 - forward declare mozilla::MediaRawData in mp4_demuxer/Index.h

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Ralph Giles (:rillian)]

Attachment: Fix

Hit this trying to hook up a gtest for MP4Metadata.

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8621895 [details] [diff] [review]
Fix

Review of attachment 8621895 [details] [diff] [review]:
-----------------------------------------------------------------

MediaRawData is returned by GetNext()

I don't like to use forward declaration in that case. 
To me a function declared in a header must be wholly contained in that header for both the declaration and the object returned.  

Here the user of Index.h will also have to do #include MediaData.h in order to use GetNext()

So instead I would include MediaData.h

Comment 3

[Ralph Giles (:rillian)]

Attachment: fix v2

Thanks for the review. This better?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26804dc7a709

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/26804dc7a709