Closed Bug 1174383 Opened 8 years ago Closed 8 years ago

Fix bogus gfx/2d debug assertions that have side effects

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(1 file)

fix-MapInvalidRect-inputIndex-asserts.patch
1.55 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review 
gfx/2d/ExtendInputEffectD2D1.cpp and RadialGradientEffectD2D1.cpp have debug assertions that assign to the asserted variable instead of testing for equality:

  MOZ_ASSERT(inputIndex = 0);

However, this typo suggests that the ExtendInputEffectD2D1 and RadialGradientEffectD2D1::MapInvalidRect() functions are not actually called because these assertions would always fail because the assigned expression value is 0. :)
Attachment #8621943 - Flags: review?(bas)
Comment on attachment 8621943 [details] [diff] [review]
fix-MapInvalidRect-inputIndex-asserts.patch

Review of attachment 8621943 [details] [diff] [review]:
-----------------------------------------------------------------

It's possible, these are internal D2D functions and they're required to be implemented by the effect spec, I'm not so certain D2D actually calls them :).
Attachment #8621943 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/600c02fb4be2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.