Fix bogus gfx/2d debug assertions that have side effects

RESOLVED FIXED in Firefox 41

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

gfx/2d/ExtendInputEffectD2D1.cpp and RadialGradientEffectD2D1.cpp have debug assertions that assign to the asserted variable instead of testing for equality:

  MOZ_ASSERT(inputIndex = 0);

However, this typo suggests that the ExtendInputEffectD2D1 and RadialGradientEffectD2D1::MapInvalidRect() functions are not actually called because these assertions would always fail because the assigned expression value is 0. :)
Attachment #8621943 - Flags: review?(bas)
Comment on attachment 8621943 [details] [diff] [review]
fix-MapInvalidRect-inputIndex-asserts.patch

Review of attachment 8621943 [details] [diff] [review]:
-----------------------------------------------------------------

It's possible, these are internal D2D functions and they're required to be implemented by the effect spec, I'm not so certain D2D actually calls them :).
Attachment #8621943 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/600c02fb4be2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.