1174423 - Disable font-variant: small-caps for ga-IE, evaluate exclusion of other locales

Status: RESOLVED FIXED

(www.mozilla.org :: L10N, defect)

Description

[Francesco Lodolo [:flod]]

See full discussion here
https://groups.google.com/forum/#!topic/mozilla.dev.l10n/DzhY-d_38HQ

We're currently overriding text-transform: uppercase for ga-IE. We should do the same for font-variant, to avoid small-caps. 

I don't think we currently have any CSS rule using font-variant, but it doesn't hurt to add the exclusion.

I think it would also be safe to exclude other locales with similar issues (Greek, Turkish). CCing localizers to check if they think otherwise.

Comment 1

[Francesco Lodolo [:flod]]

Might also be relevant for Scottish Gaelic (gd).

Comment 2

[Francesco Lodolo [:flod]]

List of locales with special rules (and fonts) for mozilla.org is here
https://github.com/mozilla/bedrock/tree/master/media/css/l10n/

Comment 3

[Kohei Yoshino [:kohei]]

I can send a PR shortly.

Comment 4

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request: mozilla/bedrock#3060

Comment 5

[Francesco Lodolo [:flod]]

That was super fast :-)

Let's make sure that we're not doing something we should not. 

Can you confirm that it's safer to exclude your locales from text transformations (uppercase, small-caps) for el, gd, and tr?

Comment 6

[Selim Şumlu]

Actually, mozilla.org (Bedrock) doesn't have a problem with Turkish.

text-transform: uppercase works fine as long as lang="tr" attribute is set. (This was fixed in bug 231162.)

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Selim Şumlu from comment #6)
> Actually, mozilla.org (Bedrock) doesn't have a problem with Turkish.
> 
> text-transform: uppercase works fine as long as lang="tr" attribute is set.
> (This was fixed in bug 231162.)

With all browsers? Because, for example, I noticed that Firefox works fine now with Irish, but Chrome doesn't.

Comment 8

[Selim Şumlu]

(In reply to Francesco Lodolo [:flod] from comment #7)
> (In reply to Selim Şumlu from comment #6)
> > Actually, mozilla.org (Bedrock) doesn't have a problem with Turkish.
> > 
> > text-transform: uppercase works fine as long as lang="tr" attribute is set.
> > (This was fixed in bug 231162.)
> 
> With all browsers? Because, for example, I noticed that Firefox works fine
> now with Irish, but Chrome doesn't.

Yes, works fine with Chrome and IE as well. (I didn't test with older IE versions though.)

Comment 9

[Francesco Lodolo [:flod]]

Thanks for checking. Added the "New Tab controls" example from bug 1171839 to http://codepen.io/flodolo/pen/KpqYjX

Looks like only Firefox and IE11 gets the small-caps correctly.

Comment 10

[Alfredos-Panagiotis Damkalis [:fredy]]

Since bug 307039 was fixed, capitalizing letters works fine in el locale. (there is a issue with disjunctive eta as you can see on the last comments of that bug but it doesn't cause any serious problems).

I leave ni on Iosif as I am not very familiar with mozilla.org site needs, so I don't know if there is any other reason of disabling capitalizing on el locale.

Comment 11

[Selim Şumlu]

(In reply to Francesco Lodolo [:flod] from comment #9)
> Thanks for checking. Added the "New Tab controls" example from bug 1171839
> to http://codepen.io/flodolo/pen/KpqYjX
> 
> Looks like only Firefox and IE11 gets the small-caps correctly.

You're right, Francesco. My tests were directly on mozilla.org/tr, which doesn't make use of small-caps at the moment.

Please override ONLY small-caps for Turkish.

Comment 12

[Francesco Lodolo [:flod]]

I realize that I should have CCed Jonathan Kew from the start, since he probably knows more than everyone I know about this matter.

Also: https://developer.mozilla.org/en-US/docs/Web/CSS/text-transform

We probably want to replicate what we do for Turkish for Azerbaijani.

Added Greek and German examples, looks like small-caps works really badly in Chrome.

Comment 13

[Iosif Psychas [:TheGallery]]

small-caps does look bad in Chrome for el but I can't recall using it across mozilla.org unless I missed it. I am not sure what percentage of strings this might affect.

Comment 14

[Craig Cook (:craigcook)]

We've had a pull request (https://github.com/mozilla/bedrock/pull/3060) open for this issue for some time, but it's marked as a work in progress pending more discussion on this bug. Have there been any new developments?

I also don't think we use small-caps anywhere at present but it's not a bad idea to include an override just in case it ever comes up (for those locales that need it). The PR currently overrides both text-transform and font-variant for el, ga-IE, gd, and tr. Any others we should add?

Comment 15

[Francesco Lodolo [:flod]]

Looks like the agreement is to disable small-caps, and keep things as they are for uppercase, since support is good.

I'd say we go ahead with that, close this bug, and eventually reopen if one specific locale needs to disable it.

Comment 16

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/fac732dc76de7ee77434ff94017648a26ada6b6d
Fix Bug 1174423 - Disable font-variant: small-caps for ga-IE, evaluate exclusion of other locales

https://github.com/mozilla/bedrock/commit/c34f91e42e86bb4303dd82332b3a486f3d6e1bb3
Merge pull request #3060 from kyoshino/bug-1174423-l10n-css

Fix Bug 1174423 - Disable font-variant: small-caps for ga-IE, evaluate exclusion of other locales