1174434 - The context menu bookmark star state doesn't update when the bookmarks button has been moved out of the toolbar

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
1) Open mozilla.com
2) Click the bookmark star in the toolbar to make the page a bookmark
3) Open the context menu
4) See that the star in the context menu is filled in
5) Switch tabs to a non-bookmarked page
6) Remove the bookmarks button from the toolbar (right-click, remove from toolbar)
7) Switch back to mozilla.com tab
8) Open context menu

Expected result:
The star is filled-in in the context menu

Actual result:
The star is empty

A second related issue is that the star should be disabled when the context menu is opened on the new tab page (or any time that the URL in the location bar has been modified but not visited yet [invalid page proxy state]). This also doesn't work when the button is removed from the toolbar.

Comment 1

[atlanto]

You may know that it is probably caused by
https://hg.mozilla.org/mozilla-central/file/tip/browser/base/content/browser-places.js#l1269
1268>  _shouldUpdateStarState: function() {
1269>    return this._currentAreaType == CustomizableUI.TYPE_TOOLBAR;
1270>  },

It may be necessary to add a condition indicating that it is processing the context menu.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

We also don't update star when it is placed in the menu panel (hamburger menu). The star is always filled in and the tooltip always says "Bookmark this page".

Comment 3

[Mathew Hodson]

This was fixed by bug 1352120 with https://hg.mozilla.org/mozilla-central/rev/ffcc7b9e7baaf11c375619d296aac1f90c2aaaff

I think we can make this as depends on 1352120 and then close it fixed.