Selected item in the report view is colored in blue hiding verdict color

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jonathan.pigree, Assigned: jonathan.pigree)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

333.35 KB, image/png
parkouss
: review+
Details
PR
49 bytes, text/x-github-pull-request
parkouss
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Now that we have verdict colored cells in the report view, the blue color when selecting a cell is hiding the verdict color of this cell.

Handling in the delegate (report_delegate.py) or using a stylesheet are the way to go I think.
(Assignee)

Updated

3 years ago
Assignee: nobody → jonathan.pigree
(Assignee)

Comment 1

3 years ago
Created attachment 8623805 [details]
Screenshot
Attachment #8623805 - Flags: review?(j.parkouss)
(Assignee)

Comment 2

3 years ago
Created attachment 8623814 [details] [review]
PR
Attachment #8623814 - Flags: review?(j.parkouss)
Comment on attachment 8623805 [details]
Screenshot

Looks great!
Attachment #8623805 - Flags: review?(j.parkouss) → review+
Comment on attachment 8623814 [details] [review]
PR

Seems all good to me. :)
Attachment #8623814 - Flags: review?(j.parkouss) → review+
Thanks Jonathan! This looks good, at least on my gnome desktop. :)

I merged this manually in https://github.com/mozilla/mozregression/commit/ef9f82faa352ab4e9d2373e22bbd651936ae1cbb.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.