Closed Bug 1174486 Opened 5 years ago Closed 5 years ago

Stop using JS_ReportPendingException in the javascript: protocol handler and nsJSUtils

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(4 files, 3 obsolete files)

5.56 KB, patch
bholley
: review+
Details | Diff | Splinter Review
4.82 KB, patch
bholley
: review+
Details | Diff | Splinter Review
15.00 KB, patch
bholley
: review+
Details | Diff | Splinter Review
1.18 KB, patch
bholley
: review+
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Oh, this is riduculous.  Resummarizing to the whole ball of string involved in fixing this.
Summary: Stop using JS_ReportPendingException in the javascript: protocol handler → Stop using JS_ReportPendingException in the javascript: protocol handler and nsJSUtils
Attachment #8622027 - Attachment is obsolete: true
Attachment #8622027 - Flags: review?(bobbyholley)
Btw, the try run from that first patch shows it failing in the expected way: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4882c4d823e3
This is needed for some cases that currently report an exception and then do
some other work on the same cx (specifically, nsXBLProtoImplField::InstallField).
Attachment #8622032 - Flags: review?(bobbyholley)
Attachment #8622034 - Attachment is obsolete: true
Attachment #8622034 - Flags: review?(bobbyholley)
Attachment #8622181 - Attachment is obsolete: true
Attachment #8622181 - Flags: review?(bobbyholley)
Attachment #8622032 - Flags: review?(bobbyholley) → review+
Attachment #8622033 - Flags: review?(bobbyholley) → review+
Comment on attachment 8622182 [details] [diff] [review]
part 4.  Stop reporting exceptions in nsJSUtils::EvaluateString and have its consumers use AutoJSAPIs that take ownership of error reporting instead

Review of attachment 8622182 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsJSUtils.cpp
@@ -98,5 @@
>    return innerWindowID;
>  }
>  
> -void
> -nsJSUtils::ReportPendingException(JSContext *aContext)

\o/ So glad to see this gone.
Attachment #8622182 - Flags: review?(bobbyholley) → review+
Comment on attachment 8622183 [details] [diff] [review]
part 3.  Make sure that warnings do still get reported even if our AutoJSAPI has taken over error reporting

Review of attachment 8622183 [details] [diff] [review]:
-----------------------------------------------------------------

Nit - Make this part 0?

Thanks for working on this stuff!
Attachment #8622183 - Flags: review?(bobbyholley) → review+
Depends on: 1181619
Blocks: 1070049
Blocks: 1099425
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.