Closed Bug 1174504 Opened 6 years ago Closed 6 years ago

logical-coordinate versions of nsIFrame::SetSize should maintain the frame's logical position

Categories

(Core :: Layout: Block and Inline, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When changing a frame's size using logical coordinates, it makes more sense for the frame's logical position to stay unchanged, rather than its physical origin.

Fixing this doesn't currently affect any reftests (https://treeherder.mozilla.org/#/jobs?repo=try&revision=c011056def55), but will be helpful during the conversion of table layout (which is what brought it to my attention).
Comment on attachment 8622047 [details] [diff] [review]
Logical-coordinate versions of nsIFrame::SetSize should maintain the frame's logical position

Review of attachment 8622047 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this looks good, and as far as I can tell there aren't any callers of SetSize that already do this (a concern I brought up on IRC)
Attachment #8622047 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/7160a4175889
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.