1174510 - fallback from unsupported (.ani) css cursor url() to a supported url() no longer working

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[westor]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150605094246

Steps to reproduce:

I had add an code so i can change my website cursor but is not working under firefox, other browsers are ok.

Firefox: http://goo.gl/F2yz3y
IE: http://goo.gl/sZvyTt


Actual results:

Not working the website cursor


Expected results:

Sync the website cursor to be correct

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release] : Regression since Firefox36

Steps to reproduce:

The css is,
body, a:hover {
    cursor: url("http://cur.cursors-4u.net/cursors/cur-8/cur736.ani"), url("http://cur.cursors-4u.net/cursors/cur-8/cur736.png"), progress !important;
}

Actual Results:
Error in parsing value for 'cursor'.  Declaration dropped. 914.css:40:29



Regression pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f129b17f9067&tochange=f245578c4fa4

Regressed by: Bug 1084136

Comment 2

[westor]

What all of these mean? its my fault or an firefox problem?

Comment 3

[Alice0775 White]

This is Firefox problem

Comment 4

[Alice0775 White]

Via local build
Last good: e0b56aa7e3b0
First bad: 179a94abc0b3

Regressed by: 	179a94abc0b3	Seth Fowler — Bug 1084136 (Part 10) - Materialize image status from image state when needed. r=tn

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 40+.  I don't think we can take a fix for this for 39 at this point.

Comment 6

[Seth Fowler [:seth] [:s2h]]

Hmm, interesting. It's not at all obvious to me how that patch could affect *parsing*.

Comment 7

[Alice0775 White]

Attachment: reduced

Comment 8

[Alice0775 White]

Back the offending bug out, please

Comment 9

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 10

[Seth Fowler [:seth] [:s2h]]

(In reply to Alice0775 White from comment #8)
> Back the offending bug out, please

No. It's not even feasible to do so; that patch landed *8 months ago*.

This will get fixed, but it will take some time for me to get to it. Please respect the fact that I have to prioritize bugs that are more serious, affect more people, or have tighter deadlines for whatever reason.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Untracking for ESR38 release as this does not meet the ESR triage bar which primarily includes security related bug fixes and issues that have a significant end-user impact.

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

This has been deemed a lower priority (comment 10) and there is no fix. Marking 40 as wontfix.

Seth - This is still a regression. Do you have a sense of when you'll be able to prioritize this bug based on your current workload? Is 41 a realistic target or are we looking at a later release?

Comment 13

[Seth Fowler [:seth] [:s2h]]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #12)
> This has been deemed a lower priority (comment 10) and there is no fix.
> Marking 40 as wontfix.
> 
> Seth - This is still a regression. Do you have a sense of when you'll be
> able to prioritize this bug based on your current workload? Is 41 a
> realistic target or are we looking at a later release?

I think 41 is realistic, yeah.

Comment 14

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Seth, do you still believe we may have a patch for FF41? We are almost a week away from building 41 RC and therefore the urgency to uplift if we have a fix in the works.

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

We are getting close to the end of the 41 release cycle. I see little choice here other than wontfix'ing for 41. Please let me know if there are any concerns.

Comment 17

[westor]

LOL!! Any solution about this cursor problem ??? did noone has an workaround about fixing this bug cursor for firefox ??

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: MozReview Request: Bug 1174510 - Fix fallback from cursor formats that we don't support or that fail to decode to other cursor files. r?seth

Bug 1174510 - Fix fallback from cursor formats that we don't support or that fail to decode to other cursor files.  r?seth

Although I didn't test this theory, I think it's fixing a regression
from patch 3 in bug 1084136 (changeset e7ecd25d7e7c), which stopped
clearing other flags when an error occurred.

Comment 19

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8657465 [details]
MozReview Request: Bug 1174510 - Fix fallback from cursor formats that we don't support or that fail to decode to other cursor files.  r?seth

Looks good. Thanks for taking this on, David.

Comment 20

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72b0bd6c92fc

Comment 21

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/72b0bd6c92fc

Comment 22

[Sylvestre Ledru [:Sylvestre]]

David, are you planning to request an uplift to 42 for this patch? Thanks

Comment 23

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8657465 [details]
MozReview Request: Bug 1174510 - Fix fallback from cursor formats that we don't support or that fail to decode to other cursor files.  r?seth

Approval Request Comment
[Feature/regressing bug #]: Bug 1084136
[User impact if declined]: we never fall back to later url() values for the CSS cursor property when an earlier url loads successfully but is not supported (e.g., an .ani cursor)
[Describe test coverage new/current, TreeHerder]: doesn't have automated test coverage since it's hard to test right now
[Risks and why]: very low risk; it simply skips images that have an error to restore the old behavior
[String/UUID change made/needed]: no

Comment 24

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8657465 [details]
MozReview Request: Bug 1174510 - Fix fallback from cursor formats that we don't support or that fail to decode to other cursor files.  r?seth

Thanks. Let's take this long standing bug.

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4c1390cd396a

Comment 26

[Sayed Mohammad Amir [:smamir]]

I have reproduced the bug with Firefox Nightly 41.0a1(20150614030204) on Windows 7 64 bit.

Verified as fixed with Firefox Beta 43.0b7(20151126120800)

UA:
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:41.0) Gecko/20100101 Firefox/41.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0

Comment 27

[Nazir Ahmed Sabbir [:NaSb]]

Reproduced this bug by following comment 0 with Firefox Nightly 41.0a1 (2015-06-14); 
(Build ID: 20150614030204) on Linux, 64 Bit

This Bug is now verified as fixed on Latest Firefox Beta 43.0b7

Build ID 	20151126120800
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0