Closed
Bug 1174543
Opened 9 years ago
Closed 9 years ago
[computed view] Expanded matched rules are sometimes duplicated
Categories
(DevTools :: Inspector, defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: arni2033, Assigned: gl)
References
Details
Attachments
(3 files, 1 obsolete file)
|
37.95 KB,
image/png
|
Details | |
|
965 bytes,
patch
|
miker
:
review+
|
Details | Diff | Splinter Review |
|
3.59 KB,
patch
|
gl
:
review+
|
Details | Diff | Splinter Review |
[ruleview] Rules are duplicating in some cases.png
// STR: 1. Run Fx 40.0a2 (2015-06-12) 2. Open any image by direct link 3. Open Inspector, Ruleview -> "Computed". Inspect the <img> element 4. Type 'margin-top' in filter on "Computed" tab of Ruleview 5. Open drop-down list on that tab (like on attachment image) 6.a) Switch between <img> and <body> several times 6.b) Switch between "Computed" and "Rules" tabs of Ruleview several times // Result: Rules were duplicating. (This happens REGARDLESS of the E10S state)
|
||
Comment 1•9 years ago
|
||
Good catch, thank you for the report. This is most likely a fall out form bug 1120616. CCing Gabriel so he can confirm.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → Unspecified
Summary: [ruleview] Displayed rules are duplicating in some cases → [computed view] Expanded matched rules are sometimes duplicated
|
Assignee | |
Comment 2•9 years ago
|
||
I reviewed my changes to computed-view.js in bug 1120616, and nothing stood out to me that should be causing this issue. I haven't looked deeper into the existing code to see what the issue is.
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → gabriel.luong
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8631783 -
Flags: review?(mratcliffe)
|
|
Assignee | |
Comment 4•9 years ago
|
||
This seems to be a regression from Bug 1136257 where we stopped using the templater.
|
|
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8631821 -
Flags: review?(mratcliffe)
|
|
Assignee | |
Comment 6•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7130f1d5836
Comment on attachment 8631783 [details] [diff] [review] Part 1: Remove processTemplate code Review of attachment 8631783 [details] [diff] [review]: ----------------------------------------------------------------- One small nit: You should also be able to remove .rule-text { from browser/themes/shared/devtools/computedview.css:128 because that was a fix for the templater breaking the computed view on rtl locales.
Attachment #8631783 -
Flags: review?(mratcliffe) → review+
Attachment #8631821 -
Flags: review?(mratcliffe) → review+
|
|
Assignee | |
Comment 8•9 years ago
|
||
Attachment #8631783 -
Attachment is obsolete: true
Attachment #8632303 -
Flags: review+
|
|
Assignee | |
Comment 9•9 years ago
|
||
Removed .rule-text
|
||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a5b53890b922 https://hg.mozilla.org/integration/fx-team/rev/7b6e415628ff
|
||
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a5b53890b922 https://hg.mozilla.org/mozilla-central/rev/7b6e415628ff
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•