1174568 - Pinterest loads with a black SVG favicon instead of their red ICO favicon. (They provide both.)

Status: VERIFIED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Daniel Holbert [:dholbert]]

In Firefox Nightly, ever since bug 366324 landed (making SVG favicons work more reliably), Pinterest loads with a black favicon.

This is because the last favicon they provide *is* an entirely black SVG:

    <link rel="icon" href="https://s-passets-cache-ak0.pinimg.com/webapp/style/app/common/images/favicon.b6b02d9c.png">
    <link rel="icon" sizes="any" mask href="https://s-passets-cache-ak0.pinimg.com/webapp/style/app/common/images/pinterest_badge.ccdac53e.svg">


They're trying to use this Apple/Safari feature:
https://developer.apple.com/library/safari/releasenotes/General/WhatsNewInSafari/Articles/Safari_9.html#//apple_ref/doc/uid/TP40014305-CH9-SW20
and they're aiming to colorize the icon (in Safari) with this tag:
    <meta name="theme-color" content="#bd081c">


But they're apparently going against Apple's recommendation of putting the black SVG icon *before* other favicons.  (MattN says we honor the last favicon we see, and right now that's this all-black SVG favicon.)

So: we (and any other browsers that support SVG favicons) need Pinterest to reorder these favicons so that the all-black SVG one comes before the ICO one. (per Apple's recommendation in their developer documentation linked above) 

See also bug 1174548 and bug 1174552 (for same issue at Yelp and Twitter).

Comment 1

[Michael Ellis]

Mike - This is a pretty easy fix, could you have your team take a look at this bug? (See Comment 1)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug

This reproduces in all versions of Firefox -- here's a screenshot with current release on linux.

(On versions < 41, the bug only shows up on first load -- that's due to an unrelated firefox bug with handling cached svg favicons, which was fixed in bug 366324. So in 41 and newer, this black favicon is all we ever show, because it's the one that Pinterest is providing last in their markup.)

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

I submitted a fix to our templates which should be deployed at 1pm PT today. Thanks for flagging!

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Deploy completed; should be able to verify this one now.

Comment 5

[Mike Taylor [:miketaylr]]

Yep, looks great. Thanks!