Closed
Bug 1174582
Opened 7 years ago
Closed 7 years ago
Videos with negative time frames gets evicted.
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(3 files)
2.45 KB,
patch
|
ayang
:
review+
|
Details | Diff | Splinter Review |
1.05 KB,
patch
|
ayang
:
review+
|
Details | Diff | Splinter Review |
1.11 KB,
patch
|
ayang
:
review+
|
Details | Diff | Splinter Review |
Some MP4 videos starts with a keyframe that has a negative presentation time stamp. Those videos do not play well. The new MSE code following the spec evicts them automatically as they are not within Window Append Start (default:0) / Window Append End (default:+oo). And the MP4Reader / MediaFormatReader kick the skip to next keyframe logic.
Assignee | ||
Comment 1•7 years ago
|
||
Some videos have negative start time, as the default window size restriction is [0, oo) those frames would be evicted (and as they are typically keyframes, rendering the content unplayable from the start.
Attachment #8622189 -
Flags: review?(cpearce)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8622190 -
Flags: review?(cpearce)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jyavenard
Comment 4•7 years ago
|
||
Comment on attachment 8622189 [details] [diff] [review] P1. Relax append window restrictions. Review of attachment 8622189 [details] [diff] [review]: ----------------------------------------------------------------- Passing review to Alfredo. Thanks for taking on this responsibility Alfredo!
Attachment #8622189 -
Flags: review?(cpearce) → review?(ayang)
Comment 5•7 years ago
|
||
Comment on attachment 8622190 [details] [diff] [review] P2. Do not skip keyframe with negative timestamp. Review of attachment 8622190 [details] [diff] [review]: ----------------------------------------------------------------- Passing review to Alfredo. Thanks for taking on this responsibility Alfredo!
Attachment #8622190 -
Flags: review?(cpearce) → review?(ayang)
Comment 6•7 years ago
|
||
Comment on attachment 8622191 [details] [diff] [review] P3. Do not skip keyframe with negative timestamp. Review of attachment 8622191 [details] [diff] [review]: ----------------------------------------------------------------- Passing review to Alfredo. Thanks for taking on this responsibility Alfredo!
Attachment #8622191 -
Flags: review?(cpearce) → review?(ayang)
Comment 7•7 years ago
|
||
Could you please attach a video with "negative PTS" first key frame? Just curious with this kind of video and it probably has the same problem on normal playback. Thank you.
Flags: needinfo?(jyavenard)
Assignee | ||
Comment 8•7 years ago
|
||
Those are Youtube videos, plenty of them.. let me see if I can grab some.
Flags: needinfo?(jyavenard)
Assignee | ||
Comment 9•7 years ago
|
||
I'm going to rpending those, because I don't want to wait any longer and it prevents some youtube videos to play.
Comment 10•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/79c9064338e7 https://hg.mozilla.org/integration/mozilla-inbound/rev/b894e485d1d4 https://hg.mozilla.org/integration/mozilla-inbound/rev/499e2b9b0f50
Comment 11•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/79c9064338e7 https://hg.mozilla.org/mozilla-central/rev/b894e485d1d4 https://hg.mozilla.org/mozilla-central/rev/499e2b9b0f50
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Updated•7 years ago
|
Attachment #8622189 -
Flags: review?(ayang) → review+
Updated•7 years ago
|
Attachment #8622190 -
Flags: review?(ayang) → review+
Updated•7 years ago
|
Attachment #8622191 -
Flags: review?(ayang) → review+
Assignee | ||
Comment 12•7 years ago
|
||
ayang: I was just provided such video which on anything but nightly will cause the first 2s of video to be non-decodable (as the first keyframe at -83377) http://videojs.viewlorium.com/watch.php?brittany-murphy-story
Flags: needinfo?(ayang)
You need to log in
before you can comment on or make changes to this bug.
Description
•