1174582 - Videos with negative time frames gets evicted.

Status: RESOLVED FIXED

Description

[Jean-Yves Avenard [:jya]]

Some MP4 videos starts with a keyframe that has a negative presentation time stamp.

Those videos do not play well. The new MSE code following the spec evicts them automatically as they are not within Window Append Start (default:0) / Window Append End (default:+oo).

And the MP4Reader / MediaFormatReader kick the skip to next keyframe logic.

Comment 1

[Jean-Yves Avenard [:jya]]

Created attachment 8622189 [details] [diff] [review]
P1. Relax append window restrictions.

Some videos have negative start time, as the default window size restriction
is [0, oo) those frames would be evicted (and as they are typically keyframes, rendering
the content unplayable from the start.

Comment 2

[Jean-Yves Avenard [:jya]]

Created attachment 8622190 [details] [diff] [review]
P2. Do not skip keyframe with negative timestamp.

Comment 3

[Jean-Yves Avenard [:jya]]

Created attachment 8622191 [details] [diff] [review]
P3. Do not skip keyframe with negative timestamp.

MP4Reader.

Comment 4

[Chris Pearce (:cpearce)]

Comment on attachment 8622189 [details] [diff] [review]
P1. Relax append window restrictions.

Review of attachment 8622189 [details] [diff] [review]:
-----------------------------------------------------------------

Passing review to Alfredo. Thanks for taking on this responsibility Alfredo!

Comment 5

[Chris Pearce (:cpearce)]

Comment on attachment 8622190 [details] [diff] [review]
P2. Do not skip keyframe with negative timestamp.

Review of attachment 8622190 [details] [diff] [review]:
-----------------------------------------------------------------

Passing review to Alfredo. Thanks for taking on this responsibility Alfredo!

Comment 6

[Chris Pearce (:cpearce)]

Comment on attachment 8622191 [details] [diff] [review]
P3. Do not skip keyframe with negative timestamp.

Review of attachment 8622191 [details] [diff] [review]:
-----------------------------------------------------------------

Passing review to Alfredo. Thanks for taking on this responsibility Alfredo!

Comment 7

[Alfredo Yang (:alfredo)]

Could you please attach a video with "negative PTS" first key frame? Just curious with this kind of video and it probably has the same problem on normal playback.
Thank you.

Comment 8

[Jean-Yves Avenard [:jya]]

Those are Youtube videos, plenty of them.. let me see if I can grab some.

Comment 9

[Jean-Yves Avenard [:jya]]

I'm going to rpending those, because I don't want to wait any longer and it prevents some youtube videos to play.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79c9064338e7
https://hg.mozilla.org/integration/mozilla-inbound/rev/b894e485d1d4
https://hg.mozilla.org/integration/mozilla-inbound/rev/499e2b9b0f50

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/79c9064338e7
https://hg.mozilla.org/mozilla-central/rev/b894e485d1d4
https://hg.mozilla.org/mozilla-central/rev/499e2b9b0f50

Comment 12

[Jean-Yves Avenard [:jya]]

ayang: I was just provided such video which on anything but nightly will cause the first 2s of video to be non-decodable (as the first keyframe at -83377)
http://videojs.viewlorium.com/watch.php?brittany-murphy-story

Comment 13

[Alfredo Yang (:alfredo)]

Thank you!