Closed Bug 1174594 Opened 5 years ago Closed 5 years ago

Remove PL_DHashTableEnumerate() use from XPConnect

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(3 files)

Because PLDHashTable::Iter is much nicer than PL_DHashTableEnumerate().
Each PLDHashTable-based map class in XPCMaps has its Enumerate() function
replaced with an Iterator and/or a RemovingIterator.
Attachment #8624344 - Flags: review?(mrbkap)
It's written to but never read from.
Attachment #8624349 - Flags: review?(mrbkap)
Attachment #8624344 - Flags: review?(mrbkap) → review+
Attachment #8624348 - Flags: review?(mrbkap) → review+
Comment on attachment 8624349 [details] [diff] [review]
(part 3) - Remove ShutdownData

Review of attachment 8624349 [details] [diff] [review]:
-----------------------------------------------------------------

https://xkcd.com/1172/
Attachment #8624349 - Flags: review?(mrbkap) → review+
Thank you for the fast reviews.
Flags: needinfo?(alvestom88)
alvestom88, did you mean to "needinfo" yourself on this bug?
Flags: needinfo?(alvestom88)
You need to log in before you can comment on or make changes to this bug.