1174605 - Additional support for sending special data to old versions

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Spun off from bug 998721 - rstrong requests that this is possible for these major Firefox versions:

2.0.0.20 and 3.0 - the version equal must the existing app version and the extensionVersion should be omitted.

3.5 - the version can equal 12 and the extensionVersion should be omitted.

3.6 and above - the version can equal 12 and the extensionVersion should equal the app version that is checking for updates.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: PR to add funky faking for old version

This pull request
* renames setExtvToIncomingVersion to oldVersionSpecialCases, to better reflect what it does (TODO - update Firefox-12.0-build1-schema1 in prod when this lands)
* adds special casing based on the query version
* adds tests for each special case

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8696541 [details] [review]
PR to add funky faking for old version

Pls see comment #1 for comments.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 8696541 [details] [review]
PR to add funky faking for old version

Thanks for driving this home/fixing it up!

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/16c314a14f2671aaa3d779dde7220cf1a37351b2
Merge pull request #31 from nthomas-mozilla/fake-it

Bug 1174605 - Fake data for old versions

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

I think Ben is planning a deployment soon, leaving this open until then.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 8696541 [details] [review]
PR to add funky faking for old version

This patch is in production now.