Closed
Bug 1174658
Opened 9 years ago
Closed 9 years ago
[Stingray][Dashboard] Intro launch animation for dashboard - Central Clock and Background
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S3 (24Jul)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: rexboy, Assigned: yifan)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(2 files, 1 obsolete file)
+++ This bug was initially created as a clone of Bug #1168043 +++ We still need to pop up date on intro launch, and zoom-in the background. See[1]: [1]: https://docs.google.com/a/mozilla.com/file/d/0B2-G3kew1WpXVUxfZ2VlZVBMbUU/edit
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → yliao
|
|
Assignee | |
Comment 1•9 years ago
|
||
* Add background and greeting animations. * Change mozl10n.get() to mozl10n.formatValue().
Attachment #8630853 -
Flags: review?(rexboy)
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8630853 [details] [review] pull request Looks great but some little changes. And 3d-translate according to our discussion earlier. See my comments on Github.
Attachment #8630853 -
Flags: review?(rexboy)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8630853 [details] [review] pull request Thank you! Issues have been addressed. Please review the changes.
Attachment #8630853 -
Flags: review?(rexboy)
|
|
Reporter | |
Comment 4•9 years ago
|
||
Comment on attachment 8630853 [details] [review] pull request Looks good to me, but see my comments on Github before landing.
Attachment #8630853 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Thanks! The nit is fixed. Merged into master.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Comment 6•9 years ago
|
||
sorry had to revert that push because that push broke GU Tests like https://treeherder.mozilla.org/logviewer.html#?job_id=2283529&repo=b2g-inbound
Status: RESOLVED → REOPENED
Flags: needinfo?(yliao)
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8630853 [details] [review] pull request Fix unit test failure. The mocked formatValue method in mock_l10n.js is not well designed for test condition like this. So here the test code is commented out until the mock_l10n.js is changed.
Flags: needinfo?(yliao)
Attachment #8630853 -
Flags: review+ → review?(rexboy)
|
|
Reporter | |
Comment 8•9 years ago
|
||
Comment on attachment 8630853 [details] [review] pull request I didn't see changes on it. Did you updated your pull request?
Attachment #8630853 -
Flags: review?(rexboy)
|
||
Comment 9•9 years ago
|
||
|
|
Assignee | |
Comment 10•9 years ago
|
||
Sorry that forgot to create a new one. Thanks!
Attachment #8633922 -
Flags: review?(rexboy)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8630853 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 11•9 years ago
|
||
Comment on attachment 8633922 [details] [review] pull request Looks ok to me. If possible, please describe the testing issue about formatValue further.
Attachment #8633922 -
Flags: review?(rexboy) → review+
|
||
Comment 13•9 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/77bc0d940bde2a5d2d4dfadfcccc6d8d77456d36
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S3 (24Jul)
You need to log in
before you can comment on or make changes to this bug.
Description
•