1174658 - [Stingray][Dashboard] Intro launch animation for dashboard - Central Clock and Background

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

+++ This bug was initially created as a clone of Bug #1168043 +++
We still need to pop up date on intro launch, and zoom-in the background.
See[1]:

[1]: https://docs.google.com/a/mozilla.com/file/d/0B2-G3kew1WpXVUxfZ2VlZVBMbUU/edit

Comment 1

[yifan [:yifan][:yliao]]

Attachment: pull request

* Add background and greeting animations.
* Change mozl10n.get() to mozl10n.formatValue().

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8630853 [details] [review]
pull request

Looks great but some little changes. And 3d-translate according to our discussion earlier.
See my comments on Github.

Comment 3

[yifan [:yifan][:yliao]]

Comment on attachment 8630853 [details] [review]
pull request

Thank you! Issues have been addressed. Please review the changes.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8630853 [details] [review]
pull request

Looks good to me, but see my comments on Github before landing.

Comment 5

[yifan [:yifan][:yliao]]

Thanks! The nit is fixed. Merged into master.

Comment 6

[Carsten Book [:Tomcat]]

sorry had to revert that push because that push broke GU Tests like https://treeherder.mozilla.org/logviewer.html#?job_id=2283529&repo=b2g-inbound

Comment 7

[yifan [:yifan][:yliao]]

Comment on attachment 8630853 [details] [review]
pull request

Fix unit test failure. The mocked formatValue method in mock_l10n.js is not well designed for test condition like this. So here the test code is commented out until the mock_l10n.js is changed.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8630853 [details] [review]
pull request

I didn't see changes on it. Did you updated your pull request?

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] begeeben:1174658_intro_launch_animation > mozilla-b2g:master

Comment 10

[yifan [:yifan][:yliao]]

Attachment: pull request

Sorry that forgot to create a new one. Thanks!

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8633922 [details] [review]
pull request

Looks ok to me.
If possible, please describe the testing issue about formatValue further.

Comment 12

[yifan [:yifan][:yliao]]

Thanks! Added comments in the source.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/77bc0d940bde2a5d2d4dfadfcccc6d8d77456d36