1174661 - TimeoutException in waiting for visible autocomplete suggestions in test_suggest_bookmarks_py (TestStarInAutocomplete)

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Since yesterday we have another regression in our autocomplete tests which is about the check for shown visible results. We are timing out here.

Traceback (most recent call last):
File "/Users/Mozauto/jenkins/workspace/mozilla-central_functional/venv/lib/python2.7/site-packages/marionette/marionette_test.py", line 296, in run
testMethod()
File "/Users/Mozauto/jenkins/workspace/mozilla-central_functional/venv/lib/python2.7/site-packages/firefox_ui_harness/decorators.py", line 23, in wrapper
return target(self, *args, **kwargs)
File "/Users/Mozauto/jenkins/workspace/mozilla-central_functional/venv/lib/python2.7/site-packages/firefox_ui_tests/functional/locationbar/test_suggest_bookmarks.py", line 79, in test_star_in_autocomplete
self.wait_for_condition(lambda mn: len(autocomplete_results.visible_results) == 2)
File "/Users/Mozauto/jenkins/workspace/mozilla-central_functional/venv/lib/python2.7/site-packages/marionette/marionette_test.py", line 677, in wait_for_condition
    raise TimeoutException("wait_for_condition timed out")

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b7ee8e13145a&tochange=c223b8844264

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is clearly a regression for us caused by the changes on bug 959594. So we clearly need the fix from bug 1170148 Barbara is working on.

I will temporarily skip this test.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Disabled the test via:
https://github.com/mozilla/firefox-ui-tests/commit/d8fd64110f335f0ca1ecce468aaab5715b59a4a5

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marco or Drew, while trying to fix this test failure I was wondering what happens with the old preference for enabling and disabling specific items for suggestions:

browser.urlbar.default.behavior vs. browser.urlbar.suggest.searches

Is the first pref not used anymore in favor of the new browser.urlbar.suggest.* preferences?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: github_pull_request.txt

Uploading for review already, but will wait with the landing until I got a reply from Drew or Marco.

Comment 5

[Drew Willcoxon :adw]

Right, browser.urlbar.suggest.* replaced browser.urlbar.default.behavior in bug 530209, so please use them instead.  http://hg.mozilla.org/mozilla-central/rev/af22db534027

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, thanks Drew! Interesting that this already landed for 36. Looks like our Mozmill tests which were using this old pref didn't fail so far because of the removal. Anyway those are plainly dead, and for the new Firefox UI tests this is the first test which actually makes use of that preference. So we are good in getting only this test updated and landed.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://github.com/mozilla/firefox-ui-tests/commit/9afb134f7d225117915bb5d5bf4d47be228b14f0