Remove configure block for iOS that uses MACOS_SDK_DIR

RESOLVED FIXED in 4.10.9

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

(Blocks 1 bug)

other
4.10.9
Unspecified
iOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I changed the way the iOS build works in bug 1163828, so it's no longer using --with-macos-sdk, so the configure block I added a while ago to NSPR's configure no longer works.
The root configure passes the right CC/CXX/CFLAGS/CXXFLAGS down to make this work, this just winds up breaking things now.
Attachment #8622544 - Flags: review?(wtc)
Comment on attachment 8622544 [details] [diff] [review]
bug1174749-nspr-ios-configure.patch

Review of attachment 8622544 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. Thanks.
Attachment #8622544 - Flags: review?(wtc) → review+
Comment on attachment 8622544 [details] [diff] [review]
bug1174749-nspr-ios-configure.patch

Ted: will this change make it more difficult to build NSPR
standalone (i.e., not as part of a Mozilla build) for iOS?
url:        https://hg.mozilla.org/projects/nspr/rev/25dc5f36603f7091eac40cc6c975db40151728cd
changeset:  25dc5f36603f7091eac40cc6c975db40151728cd
user:       Ted Mielczarek <ted@mielczarek.org>
date:       Tue Apr 14 15:30:36 2015 -0400
description:
bug 1174749 - remove nspr ios configure bit. r=wtc
(In reply to Wan-Teh Chang from comment #3)
> Ted: will this change make it more difficult to build NSPR
> standalone (i.e., not as part of a Mozilla build) for iOS?

Only slightly, in that users would need to explicitly pass -isysroot in CC instead of passing --with-macosx-sdk to configure. I would guess there really isn't anyone else building NSPR for iOS anyway.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.10.9
You need to log in before you can comment on or make changes to this bug.