1174768 - running dom/cache tests in e10s by themselves hits QM shutdown assert

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

If I run this:

  xvfb-run -a ./mach mochitest dom/cache --e10s

I hit:

[Parent 7714] ###!!! ASSERTION: Calling GetOrCreate() after shutdown!: 'Error', file /srv/mozilla-central/dom/quota/QuotaManager.cpp, line 1320
#01: mozilla::dom::cache::Context::QuotaInitRunnable::Run() (/srv/mozilla-central/dom/cache/Context.cpp:318)
#02: nsThread::ProcessNextEvent(bool, bool*) (/srv/mozilla-central/xpcom/threads/nsThread.cpp:846 (discriminator 1))
#03: NS_ProcessNextEvent(nsIThread*, bool) (/srv/mozilla-central/xpcom/glue/nsThreadUtils.cpp:265)
#04: nsThread::Shutdown() (/srv/mozilla-central/xpcom/threads/nsThread.cpp:645)

This is essentially a race between starting up Cache and shutting down QM.  There is no offline storage yet (because I don't have a QM reference), so I can block QM shutdown or receive notification of shutdown.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Jan, is there any way for me to detect its unsafe to call QuotaManager::GetOrCreate()?  I don't understand why it asserts since nullptr return from GetOrCreate() seems the natural way to detect this condition.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Sorry, comment 0 should read "I can't block QM shutdown".

Comment 3

[Jan Varga [:janv]]

GetOrCreate() shouldn't be called after you get Client::ShutdownWorkThreads() or if QuotaManager::IsShuttingDown() returns true.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Cache should check if QuotaManager is shutting down before calling GetOrCreate. r=janv

Thanks Jan.  This seems to fix it.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1659c5b4e48d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1659c5b4e48d