Closed Bug 1174804 Opened 9 years ago Closed 9 years ago

Newsletter form radio select for format rendered as escaped html

Categories

(developer.mozilla.org Graveyard :: Profiles, defect)

Product:
developer.mozilla.org Graveyard
Component:
Profiles
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jezdez, Assigned: jezdez)

References

Details

(Keywords: in-triage, Whiteboard: [specification][type:bug]) 

What did you do?
================
1. Go to https://developer.mozilla.org/en-US/profile/edit
2. Click "Send me the newsletter" in the right column


What happened?
==============
Seeing the format form element rendered as escaped html

What should have happened?
==========================
Seeing the format form element as a real thing

Is there anything else we should know?
======================================
Severity: normal → major
Summary: Newletter form radio select for format rendered as escaped html → Newsletter form radio select for format rendered as escaped html
Component: General → Profiles
Assignee: nobody → jezdez
Status: NEW → ASSIGNED
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/7bc9fc86c445df1799cc2946fb4c47435a663190
Fix bug 1174804 - Fix rendering of choice fields with Django >=1.7.

This is a case of a monkeypatch in jingo being out of date and a regression from us updating to a current Django release while jingo hasn't been released yet.

This makes use of https://github.com/jbalogh/jingo/commit/0d293ae8aefa0419961ab6480f38a3d2dfbadc44 and its explicit monkey patching of the `django.forms.widgets.RadioChoiceInput` class that replaces the old `django.forms.widgets.RadioInput`.

Note: There is https://github.com/jbalogh/jingo/issues/67 to ask the maintainers to do a proper release with little results yet.

https://github.com/mozilla/kuma/commit/4ef510510c89e9a89b4edc0e021fed5ee210c9fd
Merge pull request #3332 from mozilla/bug1174804

Fix bug 1174804 - Fix rendering of choice fields with Django >=1.7.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.