In Grouped View, by Subject is special cased to lack a root header row, inconsistent with all other categories

RESOLVED FIXED in Thunderbird 42.0

Status

MailNews Core
Backend
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: alta88, Assigned: alta88)

Tracking

unspecified
Thunderbird 42.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This inconsistency is jarring and unexpected and also needlessly prevents displaying a rollup count, like the others usefully have.
(Assignee)

Comment 1

2 years ago
Created attachment 8622612 [details] [diff] [review]
groupedView.patch
Attachment #8622612 - Flags: ui-review?(richard.marti)
Attachment #8622612 - Flags: ui-review?(bwinton)
Comment on attachment 8622612 [details] [diff] [review]
groupedView.patch

Yes, I think tis makes sense to add this to sort by subject.
Attachment #8622612 - Flags: ui-review?(richard.marti) → ui-review+
(Assignee)

Comment 3

2 years ago
Comment on attachment 8622612 [details] [diff] [review]
groupedView.patch


the function isn't removed because 1)that's more invasive, 2)there might be a legitimate future use case.
Attachment #8622612 - Flags: ui-review?(bwinton) → review?(rkent)
Assignee: nobody → alta88

Comment 4

2 years ago
Comment on attachment 8622612 [details] [diff] [review]
groupedView.patch

Review of attachment 8622612 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry to be so slow at this, we've been slammed by issues getting tb-38 stable.

This all looks good to me. The original "Bug 263255 - Improve thread pane UI for message grouping " mentions the plan to special-case Subject, but does not really give a good reason why.
Attachment #8622612 - Flags: review?(rkent) → review+
(Assignee)

Comment 5

2 years ago
no problem.
Keywords: checkin-needed

Comment 6

2 years ago
url:        https://hg.mozilla.org/comm-central/rev/fc7acd36923f529c46a0e825415a0a8393cf4fa4
changeset:  fc7acd36923f529c46a0e825415a0a8393cf4fa4
user:       alta88
date:       Mon Jun 15 12:40:43 2015 -0600
description:
Bug 1174832 - In Grouped View, by Subject is special cased to lack a root header row, inconsistent with all other categories. r=rkent,ui-r=paenglab

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 42.0
You need to log in before you can comment on or make changes to this bug.