Closed Bug 1174850 Opened 5 years ago Closed 5 years ago

Remove the relocatable-specific buffers

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox41 --- fixed
firefox42 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

remove_relocatable_buffers-v0.diff
11.65 KB, patch
jonco
: review+
Details | Diff | Splinter Review 
The relocatable-specific buffers were always there because managing removals from the buffers added overhead to the normal case. Once the intermediate buffer is gone via bug 1174319, however, removals no longer add any overhead. We can rip this all out now and save ourselves some complexity and duplicate code.
Attachment #8622633 - Flags: review?(jcoppeard)
Attachment #8622633 - Flags: review?(jcoppeard) → review+
Blocks: 1175642
No perf change on MacOS.
https://hg.mozilla.org/mozilla-central/rev/9c891ea3949c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Backed out for now. Bug 1174319 seems to have regressed octane and I don't have time to track this down while paying attention to work-week presentations.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/2d59ded30482
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: mozilla41 → mozilla42
You need to log in before you can comment on or make changes to this bug.