Add Firefox for iOS product

RESOLVED FIXED

Status

Input Graveyard
Submission
P1
normal
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: willkg, Assigned: willkg)

Tracking

Details

(Whiteboard: u=user c=feedback p=1 s=input.2015q3)

Attachments

(4 attachments)

(Assignee)

Description

3 years ago
edwin-after-1192812edwin-input
We need to add an iOS product to Input so we can collect feedback.

Things I need to know before we can add it:

1. need to know if we should display it on the product picker page and if so, need an icon

2. need to know if we should show it on the front page dashboard

3. need a product name

4. need the user agent (supporting parsing the user agent will be a separate bug)
cc:ing Rob so he knows.
Let me know if you need anything from me. I know Rob is pretty tied up in a lot of things right now!
This is pretty easy to do, I think. Making it 1 point.
Whiteboard: u=user c=feedback p= s=input.2015q3 → u=user c=feedback p=1 s=input.2015q3

Comment 4

3 years ago
Adding iOS folks who are getting this conversation going and should be able to clear the dependencies.  As background:
* The Input feedback portal is here: https://input.mozilla.org/en-US/feedback
* An example address for deep-linking into a product (android): https://input.mozilla.org/en-US/feedback/android?

From a discussion with Jenn it sounds like we want to launch for V1 and we'll be linking directly to Input rather than using the Input API like Android (this might change in later versions).

Per Will's dependencies
1. need to know if we should display it on the product picker page and if so, need an icon
Yes
TODO(iOS team): need icon

2. need to know if we should show it on the front page dashboard
Yes, I think that we should show it (but would be happy to hear counter-arguments)

3. need a product name
TODO(iOS team): "Firefox for iOS", right?

4. need the user agent (supporting parsing the user agent will be a separate bug)
TODO(iOS team): Need user agent
For the url, I suggest looking at the Input docs:

http://fjord.readthedocs.org/en/latest/feedback_urls.html

That allows you to specify the version as well as the locale and product. Then Input doesn't have to infer it.
Will, we are currently sending the user to:

   https://https://input.mozilla.org/feedback/fxios/$APPVERSION

(iOS will send the right locale header so I am omitting that and leaving that to the webview that we use to display this content)

The $APPVERSION is something like 1.0 or 1.0.1, etc.

Right now this redirects to a page that lists Firefox, Firefox for Android, Firefox OS, etc. Does that mean we need to register the 'fxios' identifier with you first?
Flags: needinfo?(willkg)
Ignore the copy & paste error in the previous comment. We use:

    https://input.mozilla.org/feedback/fxios/$APPVERSION

Just to avoid confusion :-)
1. need to know if we should display it on the product picker page and if so, need an icon

All the icons:

https://github.com/mozilla/firefox-ios/tree/master/Client/Assets/Images.xcassets/AppIcon.appiconset


3. need a product name

Firefox for iOS


4. need the user agent (supporting parsing the user agent will be a separate bug)

https://developer.mozilla.org/en-US/docs/Web/HTTP/Gecko_user_agent_string_reference#Firefox_for_iOS

iPhone:

Mozilla/5.0 (iPhone; CPU iPhone OS 8_3 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) FxiOS/1.0 Mobile/12F69 Safari/600.1.4

iPad:

Mozilla/5.0 (iPad; CPU iPhone OS 8_3 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) FxiOS/1.0 Mobile/12F69 Safari/600.1.4

(WebKit and iOS version numbers may differ of course)
Blocks: 1191866
Summary: add iOS product → Add Firefox for iOS product
(In reply to Stefan Arentz [:st3fan] from comment #6)
> Will, we are currently sending the user to:
> 
>    https://https://input.mozilla.org/feedback/fxios/$APPVERSION
> 
> (iOS will send the right locale header so I am omitting that and leaving
> that to the webview that we use to display this content)
> 
> The $APPVERSION is something like 1.0 or 1.0.1, etc.
> 
> Right now this redirects to a page that lists Firefox, Firefox for Android,
> Firefox OS, etc. Does that mean we need to register the 'fxios' identifier
> with you first?

Yes. This bug is for creating the ios product in Input which needs to be done before we can gather feedback. Until we add it, people going to that url will get redirected to the product picker page.
Flags: needinfo?(willkg)
Stefan: Those images are all just Firefox logos. I can use that, but I was hoping for something more distinctive.

For example, the Firefox for Android and Firefox OS logos here:

https://input.mozilla.org/en-US/feedback/

Is there something like that for Firefox for iOS? If not, I'll just use the Firefox logo.
Flags: needinfo?(sarentz)
ni Robin and Darrin, see if they have any suitable assets. See Comment 12.
Flags: needinfo?(randersen)
Flags: needinfo?(dhenein)
Created attachment 8644529 [details]
iphone-96@3x.png

This is what we use in bugzilla, not sure if it's an approved use of the logo though. Proceed with caution ;)
Flags: needinfo?(dhenein)
Created attachment 8644565 [details]
Firefox-for-iOS-iPh6-BLK.png

iPhone 6 (Black) with correct logo
Flags: needinfo?(randersen)
Created attachment 8644566 [details]
Firefox-for-iOS-iPh6-WHT.png

iPhone 6 (White) with correct logo
Removing myself from need-info, i think everything is covered now?
Flags: needinfo?(sarentz)
I just found out that SUMO has a Firefox for iOS icon already. It's a white phone with a different image in it than the attached images. Having the same icon on both Input and SUMO makes it more likely people recognize it, so I'm going to go with that one.

I think that's everything I need to create the product. I'll try to do it today.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Priority: -- → P1
:willkg would you mind attaching it so we can take a look? I attached both black and white devices, but historically have been using black devices, and the icon I used in my attachments is the "official" Firefox for iOS logo.
Flags: needinfo?(willkg)
Created attachment 8644995 [details]
fxios.gif

Firefox for iOS logo being used on SUMO.
Flags: needinfo?(willkg)
Next week is release week and I avoid doing deploys during release week. Further, Input (unfortunately) doesn't have user-uploaded image abilities, yet, so all icons have to be committed and deployed in order to show up.

Because of that and my suspicion that there's some urgency to move this along, I committed the icon I got from SUMO to the repo.

This doesn't commit us to anything. We can always push a new icon. But I'm not sure what to do with the current state of things where we've got one icon used by Bugzilla, one used by SUMO and one that's "official" (the quotes make me think it's not *really* official, but I can't think of another reason for quotes around that word).

Also, this is sort of moot since we're not showing it on the Input feedback product picker and that's the only place the icon shows up. I mention it because if what I did is not ok, we're going to want to change it before we go live.

In a PR: https://github.com/mozilla/fjord/pull/631

Landed in master: https://github.com/mozilla/fjord/commit/ec46cd1468defc64672bf3d6210b7538528ba379

Pushed to stage and prod just now.

Leaving this bug open because I still need to add some special code to our user agent parser so it can infer things when they're not given.

Comment 22

3 years ago
Correct me if I'm wrong Will, but to summarize where we are:

Pushed:
 * The fxios product category: https://input.mozilla.org/en-US/feedback/fxios/ now works

TODOs:
 * Finalize Icon
 * [Will] Finalize useragent parsing
 * [Will] Push changes to the product picker page and make the dashboard public
These changes need to be done before the September launch.

Until we make the reporting dashboard public, I'm happy to do any data pulls people need directly from the Input DB.

Thanks
Rob: Sorry about that--I should have done a summary. Your summary is right on. To clarify:

TODOs:
 * Finalize Icon
 * [Will] (code change) Finalize useragent parsing
 * [Will/Robert] (check two checkboxes on the product management page) Push changes to the product picker page and make the dashboard public
Depends on: 1192812

Comment 24

3 years ago
@Robin - Thoughts on https://bug1174883.bmoattachments.org/attachment.cgi?id=8644995 ?  Do we need to loop in anyone else?
Flags: needinfo?(randersen)

Comment 25

3 years ago
(In reply to Will Kahn-Greene [:willkg] from comment #23)
> TODOs:
>  * Finalize Icon
Pinged Robin
>  * [Will] (code change) Finalize useragent parsing
This is done in https://bugzilla.mozilla.org/show_bug.cgi?id=1192812
>  * [Will/Robert] (check two checkboxes on the product management page) Push
> changes to the product picker page and make the dashboard public
I think this needs to happen next week.  Rob to clarify timing with Karen.
(In reply to Rob from comment #24)
> @Robin - Thoughts on
> https://bug1174883.bmoattachments.org/attachment.cgi?id=8644995 ?  Do we
> need to loop in anyone else?

LGTM!

:darrin is on PTO, perhaps :antlam would like to give 2¢…
Flags: needinfo?(randersen) → needinfo?(alam)
I like yours (Robin) in comment 16 more. :) But not sure how hard would it would be to change it on the SUMO page too? It seems a bit late now.

That one (comment 24) isn't that bad, but reminds me a lot of FFOS. Since, they tend to use more of that style of cropping - whereas we don't really.

That being said, happy to get this moving.

+2¢
Flags: needinfo?(alam)
I checked in with Roland and he said to make it live, so I did that.

I think we're all set here. Marking as FIXED.

Thank you all!
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.