1174884 - Add expanded error messages for APIErrors when looking up reviewers

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P3)

Description

[Dan Minor [:dminor]]

Bug 1164127 added an error message if a reviewer is not recognized. Part of that is catching an APIError, but we might get APIErrors other than the 404 that results for an unrecognized username if something else has gone wrong.

Comment 1

[Dan Minor [:dminor]]

Attachment: MozReview Request: reviewboard: Add expanded error messages for APIErrors when looking up reviewers (bug 1174884) r?gps

reviewboard: Add expanded error messages for APIErrors when looking up reviewers (bug 1174884) r?gps

We expect APIErrors when looking up reviewers as that is what is returned if
a username does not exist. This adds code to check whether or not the error is
a 404 for an unknown user or a different error. If a different error is
encountered, the full error message is displayed.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8622738 [details]
MozReview Request: reviewboard: Add expanded error messages for APIErrors when looking up reviewers (bug 1174884) r?gps

https://reviewboard.mozilla.org/r/11439/#review9805

::: pylib/reviewboardmods/reviewboardmods/pushhooks.py:205
(Diff revision 1)
> +                    hgresp.append('display error identifying reviewer: %s: %s' %

It would be rad if we had test coverage of this branch. But whatevs, this can land without explicit review.

Comment 3

[Dan Minor [:dminor]]

Pushed to: https://hg.mozilla.org/hgcustom/version-control-tools/rev/6804a727ec8d