Closed
Bug 1174884
Opened 9 years ago
Closed 9 years ago
Add expanded error messages for APIErrors when looking up reviewers
Categories
(MozReview Graveyard :: General, defect, P3)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dminor, Assigned: dminor)
Details
Attachments
(1 file)
40 bytes,
text/x-review-board-request
|
Details |
Bug 1164127 added an error message if a reviewer is not recognized. Part of that is catching an APIError, but we might get APIErrors other than the 404 that results for an unrecognized username if something else has gone wrong.
Assignee | ||
Comment 1•9 years ago
|
||
reviewboard: Add expanded error messages for APIErrors when looking up reviewers (bug 1174884) r?gps We expect APIErrors when looking up reviewers as that is what is returned if a username does not exist. This adds code to check whether or not the error is a 404 for an unknown user or a different error. If a different error is encountered, the full error message is displayed.
Attachment #8622738 -
Flags: review?(gps)
Comment 2•9 years ago
|
||
Comment on attachment 8622738 [details] MozReview Request: reviewboard: Add expanded error messages for APIErrors when looking up reviewers (bug 1174884) r?gps https://reviewboard.mozilla.org/r/11439/#review9805 ::: pylib/reviewboardmods/reviewboardmods/pushhooks.py:205 (Diff revision 1) > + hgresp.append('display error identifying reviewer: %s: %s' % It would be rad if we had test coverage of this branch. But whatevs, this can land without explicit review.
Attachment #8622738 -
Flags: review?(gps)
Assignee | ||
Comment 3•9 years ago
|
||
Pushed to: https://hg.mozilla.org/hgcustom/version-control-tools/rev/6804a727ec8d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•