1174904 - NPR is listed as undefined in the Lookup tool

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Sign in as an admin to the lookup tool on altdev
2. Search for NPR


expected behavior:
Lookup tool find NPR and its name is listed as per https://docs.google.com/spreadsheets/d/1CPrPQ4xVsbll_vp_Bca0iWkTgg2nx7WrhCprVHwS-6Y/edit#gid=304044273

observed behavior:
For some reason, NPR is listed as undefined. Searching for NPR finds no results. But searching for 1720 finds the website.

screenshot: https://www.dropbox.com/s/tm4hgul7k0bzh2f/Screenshot%202015-06-15%2014.37.07.png?dl=0

Comment 1

[David Durst [:ddurst]]

Making this a P1, because Krupa says this "undefined" site is also not showing up on the consumer pages.

Comment 2

[Rob Hudson [:robhudson]]

There might have been something wrong with the import? The name localized string is set to NULL.

mysql> select * from websites_website where id=1720\G
*************************** 1. row ***************************
               id: 1720
          created: 2015-06-09 06:08:07
         modified: 2015-06-09 06:09:48
   default_locale: en-US
            title: 8539041
      description: 8539035
       categories: ["reference"]
        icon_type: image/png
        icon_hash: 6ed8136f
     last_updated: 2015-06-09 06:08:07
           status: 4
      is_disabled: 0
       mobile_url: NULL
              url: http://www.npr.org/
             name: 8539037
       short_name: 8539039
preferred_regions: [34, 1, 27, 25, 102, 33, 29, 28, 16, 2]
           moz_id: 2884
1 row in set (0.00 sec)

mysql> select * from translations where id=8539037;
+---------+---------+--------+------------------+------------------------+---------------------+---------------------+
| autoid  | id      | locale | localized_string | localized_string_clean | created             | modified            |
+---------+---------+--------+------------------+------------------------+---------------------+---------------------+
| 7937802 | 8539037 | en-us  |                  | NULL                   | 2015-06-09 06:08:07 | 2015-06-09 06:08:07 |
+---------+---------+--------+------------------+------------------------+---------------------+---------------------+
1 row in set (0.00 sec)

Comment 3

[Rob Hudson [:robhudson]]

Mat: Care to take a look? Lookup tool search and display seems to be working as expected given the data.

Comment 4

[Mathieu Pillard [:mat]]

There is a newline in the 'Display Title' column in the spreadsheet for this site, looks like the CSV parser didn't like that.

Looks like there are a few others in the spreadsheet:

Website.objects.filter(name__localized_string='')
[<Website: http://www.cuponatic.com>, <Website: http://www.interia.pl/>, <Website: http://www.dziennik.pl/>, <Website: http://www.sfora.pl>, <Website: http://www.easyquarto.com.br/>, <Website: http://www.economicos.cl/>, <Website: http://www.movidreams.com/>, <Website: http://www.laborum.cl/>, <Website: http://www.starpulse.com/>, <Website: http://www.beachbody.com/>, <Website: http://www.taxi.mx/>, <Website: http://futbol.univision.com/>, <Website: http://www.record.com.mx/>, <Website: http://www.tvnotas.com.mx/index.php>, <Website: http://mass.pe/>]

We need to clean the data up and re-import those.

Comment 5

[Mathieu Pillard [:mat]]

(I fixed NPR manually in both the db and the spreadsheet in the meantime)

Comment 6

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/c7701c895c0603233b5e25e85a6e7d8c2acbae83

(It's a hack, but it should be good enough)

Comment 7

[Mathieu Pillard [:mat]]

Wrong bug.

Comment 8

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/379b389fd8f2200ea82a0c3239afa18e1151ab67

Comment 9

[Madalin Cotetiu]

Searching for both NPR and 1720 does not find the site: http://screencast.com/t/5F6NtKch4A 
When searching for NPR i can find "National Public Radio": http://screencast.com/t/ZeFcqZii0
That's the desired website?

Comment 10

[Mathieu Pillard [:mat]]

"National Public Radio" is the desired website, yes (the ids changed since the bug was opened)

Comment 11

[Madalin Cotetiu]

Great, than we can close this bug. Thanks Mathieu for the fast reply.
Closing bug.