1174945 - enable eslint rules for Loop: no-shadow

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

http://eslint.org/docs/rules/no-shadow is what we'd like to enable.  Probably the easiest way to do this to just remove the "no-shadow": 0 line from .eslintrc, and allow it to revert to the default, which is:

{
    "rules": {
        "no-shadow": [2, {"hoist": "functions"}]
    }
}

Mark and Mike should feel free to chime in if they disagree...

Comment 1

[Andrei Oprea [:andreio]]

Attachment: patch.diff

Comment 2

[Andrei Oprea [:andreio]]

Attachment: patch.diff

Added in the commit message.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8623172 [details] [diff] [review]
patch.diff

Review of attachment 8623172 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for helping us avoid this pain in the future!  r=dmose with the changes requested here.

::: browser/components/loop/.eslintrc
@@ +50,5 @@
>      "no-multi-spaces": 0,         // TBD.
>      "no-new": 0,                  // TODO: Remove (use default)
>      "no-redeclare": 0,            // TODO: Remove (use default)
>      "no-return-assign": 0,        // TODO: Remove (use default)
> +    "no-shadow": [2, {"hoist": "functions"}],

I'd just delete this line entirely, so we don't inadvertently miss default values of future added options.

::: browser/components/loop/test/shared/feedbackViews_test.js
@@ +30,5 @@
>      sandbox.restore();
>    });
>  
>    // local test helpers
> +  function clickHappyFace(elem) {

This isn't really an element, it's a react component.  How about "component", here, and in similar changes.

Comment 4

[Andrei Oprea [:andreio]]

Attachment: patch.diff

Fixed review commments.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/040a407b0705

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/040a407b0705

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f12da3e08700

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f12da3e08700