Passing -r to periodic_file_updates.sh only works if what's passed is exactly `basename ${BRANCH}`

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
3 years ago
2 years ago

People

(Reporter: philor, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
This doesn't come up with the automated use of it, because we don't pass -r, but if you try to use periodic_file_updates.sh locally with an existing clone, you have to cd ~/Mozilla/releases and run ../tools/scripts/periodic_file_updates/periodic_file_updates.sh -r mozilla-beta -b releases/mozilla-beta rather than staying one level above that and using -r releases/mozilla-beta, because uses of ${REPODIR} in download_shared_artifacts assume that it is the basename, and that "tinderbox-builds/${REPODIR}" will be "tinderbox-builds/mozilla-beta" rather than "tinderbox-builds/releases/mozilla-beta" or "tinderbox-builds/~philor/code-trees/m-b".

Not only should download_shared_artifacts be using something that actually is a basename, but I think it should be using `basename ${BRANCH}` which actually has to be mozilla-beta, rather than a repo name that can be whatever someone found reasonable when they cloned.
(Reporter)

Comment 1

3 years ago
Yeah, running it locally, and development and testing by anyone who doesn't have direct access to slaves, is so very totally unsupported.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

2 years ago
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.