Closed Bug 1175037 Opened 5 years ago Closed 5 years ago

Playback may stall following resolution change

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file)

I incorrectly interpreted the "active track" flag in the "Initialization Segment Received Algorithm" (http://w3c.github.io/media-source/index.html#sourcebuffer-init-segment-received)

It is reset to false once a new init segment is received and is only used to determine if the sourcebuffer should be added to the active list.

We rely on this flag to be true to tell the MediaFormatReader that new data has been received.

Without it playback will stall as the MediaFormatReader will never attempt to fetch new samples
Comment on attachment 8622917 [details] [diff] [review]
Ensure MediaFormatReader is notified when new data is received.

Review of attachment 8622917 [details] [diff] [review]:
-----------------------------------------------------------------

Passing review to Alfredo. Thanks for taking on this responsibility Alfredo!
Attachment #8622917 - Flags: review?(cpearce) → review?(ayang)
Attachment #8622917 - Flags: review?(ayang) → review+
https://hg.mozilla.org/mozilla-central/rev/77dfa576b464
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.