Closed
Bug 1175050
Opened 10 years ago
Closed 10 years ago
Listen mozSystemWindowChromeEvent event in SystemWindow
Categories
(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evanxd, Assigned: evanxd)
Details
Attachments
(1 file)
We should listen mozSystemWindowChromeEvent event in SystemWindow because of the performance issue listed in[1]. And we will send the `mozSystemWindowChromeEvent` in shell.js[2].
[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1165134#c9
[2]: https://bug1165134.bugzilla.mozilla.org/attachment.cgi?id=8621523
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Wait for CI[1]. If it is good, let's land it.
[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=f99e83e3f6459770124362985c599cef4cb892db
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8622923 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30608
Hi Dominic,
Could you help to review the patch?
Thanks.
Attachment #8622923 -
Flags: review?(dkuo)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8622923 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30608
Looks good to me according to comment 0, the system app listens to mozSystemWindowChromeEvent instead of mozChromeEvent.
Attachment #8622923 -
Flags: review?(dkuo) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Dominic, thanks for the review.
|
|
Assignee | |
Comment 6•10 years ago
|
||
If the CI[1] is good, let's land the code.
[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=38663b3347c9315e51917cda093cfa2983270a7c
|
|
Assignee | |
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 8•10 years ago
|
||
CI was not good :D
Fixed linter issues:
master: c3185b698bc7208b45b6f7d30ca024367aad3928
You need to log in
before you can comment on or make changes to this bug.
Description
•