1175050 - Listen mozSystemWindowChromeEvent event in SystemWindow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)

Description

[Evan Tseng [:evanxd]]

We should listen mozSystemWindowChromeEvent event in SystemWindow because of the performance issue listed in[1]. And we will send the `mozSystemWindowChromeEvent` in shell.js[2].

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1165134#c9
[2]: https://bug1165134.bugzilla.mozilla.org/attachment.cgi?id=8621523

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30608

Comment 2

[Evan Tseng [:evanxd]]

Wait for CI[1]. If it is good, let's land it.

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=f99e83e3f6459770124362985c599cef4cb892db

Comment 3

[Evan Tseng [:evanxd]]

Comment on attachment 8622923 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30608

Hi Dominic,

Could you help to review the patch?

Thanks.

Comment 4

[Dominic Kuo [:dkuo]]

Comment on attachment 8622923 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30608

Looks good to me according to comment 0, the system app listens to mozSystemWindowChromeEvent instead of mozChromeEvent.

Comment 5

[Evan Tseng [:evanxd]]

Dominic, thanks for the review.

Comment 6

[Evan Tseng [:evanxd]]

If the CI[1] is good, let's land the code.

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=38663b3347c9315e51917cda093cfa2983270a7c

Comment 7

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/gaia/commit/6d941efc270505fcf604a39568248913e256b363

Comment 8

[Julien Wajsberg [:julienw]]

CI was not good :D

Fixed linter issues:
master: c3185b698bc7208b45b6f7d30ca024367aad3928