Closed Bug 1175050 Opened 7 years ago Closed 7 years ago

Listen mozSystemWindowChromeEvent event in SystemWindow

Categories

(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: evanxd, Assigned: evanxd)

Details

Attachments

(1 file)

We should listen mozSystemWindowChromeEvent event in SystemWindow because of the performance issue listed in[1]. And we will send the `mozSystemWindowChromeEvent` in shell.js[2].

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1165134#c9
[2]: https://bug1165134.bugzilla.mozilla.org/attachment.cgi?id=8621523
Comment on attachment 8622923 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30608

Hi Dominic,

Could you help to review the patch?

Thanks.
Attachment #8622923 - Flags: review?(dkuo)
Comment on attachment 8622923 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30608

Looks good to me according to comment 0, the system app listens to mozSystemWindowChromeEvent instead of mozChromeEvent.
Attachment #8622923 - Flags: review?(dkuo) → review+
Dominic, thanks for the review.
master: https://github.com/mozilla-b2g/gaia/commit/6d941efc270505fcf604a39568248913e256b363
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
CI was not good :D

Fixed linter issues:
master: c3185b698bc7208b45b6f7d30ca024367aad3928
You need to log in before you can comment on or make changes to this bug.